Associate signed contracts with OPs on accept #12423
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+217
to
+218
| fs_contract.contract.parties.create!(user:, role: :signee) | ||
| fs_contract.contract.parties.create!(external_email: cosigner_email, role: :cosigner) if cosigner_email.present? |
Contributor
There was a problem hiding this comment.
fs_contract does not have a contract.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the problem
We're currently only linking signed contracts to the organizer position in the
on_contract_signedcallback on invite, but this doesn't work before accepting an invite since the organizer position doesn't exist yet. Most contracts are signed before accepting the invite, since you can't accept an invite with a pending contract.Describe your changes
Added linking contracts to OP in the accept method on invite, and fixed the
send_contractmethod which was re-using the contract variable when it's already defined as a method on invite. This wasn't breaking anything so far, but it was performing an extra, unnecessary query.