Skip to content

Rename partner_logo to affiliate_logo and update core models/tests#643

Merged
fyliu merged 2 commits intomainfrom
feature/name_change
Mar 13, 2026
Merged

Rename partner_logo to affiliate_logo and update core models/tests#643
fyliu merged 2 commits intomainfrom
feature/name_change

Conversation

@drakeredwind01
Copy link
Member

@drakeredwind01 drakeredwind01 commented Feb 27, 2026

Fixes #602

What changes did you make?

  • Modified Affiliate model fields to match updated schema requirements.
  • Updated AffiliateSerializer to include new/renamed fields.
  • Refactored API endpoints to handle updated data structure.
  • Updated unit tests to validate model changes and endpoint responses.
  • Ran and applied new Django migrations for the Affiliate table.

Why did you make the changes (we will use this info to test)?

  • Aligns the Affiliate table with the current VRMS data model.
  • Ensures API consistency for frontend integration.-

@fyliu fyliu moved this to PR Needs review (automated column, do not place items here manually) in P: PD: Project Board Mar 6, 2026
fyliu
fyliu previously requested changes Mar 6, 2026
Copy link
Member

@fyliu fyliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drakeredwind01 You need to fill in the PR description.

  • The issue number at the top links the PR to the issue.
  • The changes portion I usually look at the code changes and say what they are
  • The reasons should answer the question "what does the project gain from making this change?"
  • You can skip the screenshots or attach what it looks like in the admin site, before and after. See this other PR description and do something like that.
  • Also, you should havae assigned a reviewer. It sets me as the reviewer after I did a review. Once you're ready, be sure to click the "re-request view" icon next to the reviwer at the top right.

@github-project-automation github-project-automation bot moved this from PR Needs review (automated column, do not place items here manually) to PR changes requested in P: PD: Project Board Mar 6, 2026
@drakeredwind01
Copy link
Member Author

@fyliu i updated the template. thanks!

@drakeredwind01 drakeredwind01 requested a review from fyliu March 13, 2026 00:27
@fyliu fyliu force-pushed the feature/name_change branch from ebbeca9 to 9373cb0 Compare March 13, 2026 00:28
@fyliu fyliu dismissed their stale review March 13, 2026 00:34

Fixed

Copy link
Member

@fyliu fyliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@fyliu fyliu merged commit 8755a4d into main Mar 13, 2026
3 checks passed
@fyliu fyliu deleted the feature/name_change branch March 13, 2026 00:37
@github-project-automation github-project-automation bot moved this from PR changes requested to ✅Done in P: PD: Project Board Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅Done

Development

Successfully merging this pull request may close these issues.

Update Table: Affiliate

2 participants