Skip to content

Cycle tab through windows instead of asking users to choose one. #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oneself wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Cycle tab through windows instead of asking users to choose one. #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 10 additions & 30 deletions scripts/background.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,40 +108,20 @@ function sendTabManager() {
if (windows.length === 1) {
// do nothing
return;
} else if (windows.length === 2) {
// send tab to only other window
utils.getCurrentTab().then((tab) => {
const otherWindow = windows.filter((filterWindow) => {
return (filterWindow.id !== tab.windowId);
});

chrome.tabs.move(tab.id, {windowId: otherWindow[0].id, index: -1});
chrome.windows.update(otherWindow[0].id, {focused: true});
chrome.tabs.update(tab.id, {selected: true});
});
} else {
// send tab to next window
utils.getCurrentTab().then((tab) => {
return utils.createTab({url : `../tabbo.html#${tab.id}`});
}).then((newTab) => {
console.log(newTab);
const onTabChange = (response) => {
if (response.tabId !== newTab.id) {
chrome.tabs.onActivated.removeListener(onTabChange);

utils.getTab(newTab.id).then(() => {
if (!chrome.runtime.lastError) {
chrome.tabs.remove(newTab.id);
}
}, (e) => {
console.error(e);
});
}
};

chrome.tabs.onActivated.addListener(onTabChange);
const currentWindowIndex = windows.findIndex(w => w.id === currentWindow.id);
var nextWindowIndex = currentWindowIndex - 1;
if (nextWindowIndex < 0) {
nextWindowIndex = windows.length - 1;
}
chrome.tabs.move(tab.id, {windowId: windows[nextWindowIndex].id, index: -1});
chrome.windows.update(windows[nextWindowIndex].id, {focused: true});
chrome.tabs.update(tab.id, {selected: true});
});
}
});
});
}

function explodeTabs() {
Expand Down