Skip to content

Enable fail-fast strategy in generate data workflow matrix#5137

Open
ludeeus wants to merge 2 commits intomainfrom
ludeeus-patch-1
Open

Enable fail-fast strategy in generate data workflow matrix#5137
ludeeus wants to merge 2 commits intomainfrom
ludeeus-patch-1

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented Mar 4, 2026

These failures are generally due to GitHub issues.
We should fast abort all on any issue, and let it run fully on the next scheduled run instead.

Copilot AI review requested due to automatic review settings March 4, 2026 06:17
@ludeeus ludeeus added the pr: action Changes to actions label Mar 4, 2026
name: Generate ${{ matrix.category }} data
strategy:
fail-fast: false
fail-fast: true
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the default value, but declaring it makes it obvious it was done on purpose.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions workflow that generates HACS category data to abort the matrix early when any category job fails, reducing wasted work during transient GitHub-related failures and allowing the next scheduled run to retry cleanly.

Changes:

  • Enable strategy.fail-fast for the category-data matrix job so other matrix runs are cancelled when one fails.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: action Changes to actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants