This commit add the support of netmap as a capture module for haka. #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is some documentation to compile and configure netmap and then start haka using netmap module. Implementation try to follow haka coding style. This is a Proof of concept and several things have to do to have a fully functionnal and stable module: - architecture have to be modified to avoid packet copy - only ipv4 packets can be filtered - code must be more modular - improve trace - add statistics mechanisms for netmap - clean code and verify memory leak or corruption
Author
|
This PR now addresses all the issues previously reported and is ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some documentation to compile and configure netmap and then start haka
using netmap module.
Implementation try to follow haka coding style.
This is a Proof of concept and several things have to do to have a fully
functionnal and stable module:
This PR replaces an earlier PR by Aragua, I have closed the old one and carried relevants comments to this new one