almost standardized the components between bic.glm.data.frame, bic.glm.formula, and bic.glm.matrix#2
Open
sbgraves237 wants to merge 7 commits intohanase:masterfrom
Open
almost standardized the components between bic.glm.data.frame, bic.glm.formula, and bic.glm.matrix#2sbgraves237 wants to merge 7 commits intohanase:masterfrom
sbgraves237 wants to merge 7 commits intohanase:masterfrom
Conversation
Author
|
I ran "git config --global core.autocrlf true" on my macOS 10.15.1 machine, per request from Hana. I don't know if this fixed anything; I hope it did, but I'm not sure. The main difference between this version and "hanase/BMA" is that names(bic.glm) are the same between the three different methods. I believe the answers are numerically equivalent, but the names in many components are different. I've also added examples to "bic.glm.Rd" to test some of these differences. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
all.equal(names(...), names(...)) between the outputs of bic.glm.data.frame, bic.glm.formula, and bic.glm.matrix. I believe the components are numerically identical, but the names are different. Fixing the names of the components is a next step.