Skip to content

Fix pending_requests_ race conditions #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hankhsu1996 merged 1 commit into from
Oct 10, 2025
Merged

Fix pending_requests_ race conditions #59

hankhsu1996 merged 1 commit into from
Oct 10, 2025

Conversation

@hankhsu1996
Copy link
Owner

@hankhsu1996 hankhsu1996 commented Oct 10, 2025

Summary

Fixed two race conditions in RpcEndpoint that could cause "Unknown request ID" errors:

  • SendMethodCall: Now waits for request registration before sending to transport
  • HandleResponse: Now waits on correct executor (endpoint_strand_) for request lookup

Changes

  • Added synchronization point in SendMethodCall to ensure request is in pending_requests_ before sending
  • Changed HandleResponse to wait on endpoint_strand_ instead of this_coro::executor

All tests pass.

@hankhsu1996 hankhsu1996 enabled auto-merge (squash) October 10, 2025 03:29
@hankhsu1996 hankhsu1996 merged commit 448d507 into main Oct 10, 2025
5 checks passed
@hankhsu1996 hankhsu1996 deleted the bugfix/pending-requests-race branch October 10, 2025 03:32
@hankhsu1996 hankhsu1996 mentioned this pull request Oct 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hankhsu1996