Some quality of life changes around invalid parameters #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The center_offset parameter doesn't work for values larger than 63 and it definitely does not work for negative values (negative values would cause overflow into the other bitfields of the MO_AGC_SYNC_TIP3). Bound the parameter similar to how we add bounds to the level parameter.
Also make sure the default value listed documented in the README.md is consistent with what is in the source code.
We also factor out bounding routine to minimize redundancy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
center_offset doesn't really make sense for negative values or values larger than 63, so we add a hard boundary to them. Also add some warnings on the console if the user passes in an invalid value.