chore(ci): reduce warnings and bump happyvertical sdk#1080
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 74177f2511
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce CI warning noise under Node 24, update the pinned @happyvertical/* SDK versions across the workspace, and remove some unused dependencies/tooling.
Changes:
- Update CI workflows and the shared setup composite action to favor Node 24 JS actions and reduce install-time warning output (including
pnpm install --loglevel error). - Bump
@happyvertical/*versions in the pnpm catalog/overrides and update dependency lists accordingly. - Remove
@langchain/communityfrom dependency/external lists and adjust package bin entries to use workspace-safe wrappers.
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.base.ts | Removes @langchain/community from the shared Rollup external list. |
| pnpm-workspace.yaml | Bumps @happyvertical/* catalog versions. |
| packages/scanner/package.json | Changes smrt-scan bin path to ./bin/... and includes bin in published files. |
| packages/core/vite.config.ts | Removes @langchain/community from core Rollup external list. |
| packages/core/package.json | Removes @langchain/community dependency and changes smrt-prebuild bin path to ./bin/... (adds bin to files). |
| packages/cli/package.json | Changes smrt/smrt-cli bin paths to ./bin/... (adds bin to files). |
| package.json | Removes semantic-release tooling devDeps; bumps @happyvertical/* overrides. |
| .github/workflows/test.yml | Sets FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 at workflow level. |
| .github/workflows/test-suite.yml | Sets FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 at workflow level. |
| .github/workflows/stale-issues.yml | Sets FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 at workflow level. |
| .github/workflows/publish.yml | Sets FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 at workflow level. |
| .github/workflows/publish-dry-run.yml | Sets FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 at workflow level. |
| .github/workflows/on-pull-request.yml | Sets FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 at workflow level. |
| .github/workflows/on-merge-main.yml | Sets FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 at workflow level. |
| .github/workflows/build.yml | Sets FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 at workflow level. |
| .github/actions/setup-environment/action.yml | Passes auth + NODE_OPTIONS=--disable-warning=DEP0169 into pnpm steps and installs with --loglevel error. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
@happyvertical/*SDK package versions and regenerate the lockfile@langchain/communityand old release toolingWhat changed
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24on the workflow entrypointsNODE_OPTIONS=--disable-warning=DEP0169to pnpm stepspnpm install --loglevel error@happyvertical/*catalog and override versions to the latest published linepnpm-lock.yamlVerification
actionlint .github/workflows/*.ymlpnpm install --frozen-lockfile --ignore-scripts --loglevel error --prefer-offlineNotes