Skip to content

chore(ci): reduce warnings and bump happyvertical sdk#1080

Merged
willgriffin merged 3 commits intomainfrom
codex/ci-warning-audit-sdk-bump
Mar 26, 2026
Merged

chore(ci): reduce warnings and bump happyvertical sdk#1080
willgriffin merged 3 commits intomainfrom
codex/ci-warning-audit-sdk-bump

Conversation

@willgriffin
Copy link
Copy Markdown
Contributor

Summary

  • reduce CI noise under Node 24 by updating workflow env/setup and quieting install-time warning output
  • update the repo's pinned @happyvertical/* SDK package versions and regenerate the lockfile
  • remove unused dependency/runtime noise sources, including @langchain/community and old release tooling

What changed

  • set FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 on the workflow entrypoints
  • ensure the shared setup action passes auth and NODE_OPTIONS=--disable-warning=DEP0169 to pnpm steps
  • run CI dependency installs with pnpm install --loglevel error
  • add workspace-safe bin wrappers for CLI/core/scanner package bins
  • bump @happyvertical/* catalog and override versions to the latest published line
  • regenerate pnpm-lock.yaml

Verification

  • actionlint .github/workflows/*.yml
  • clean temp install with pnpm install --frozen-lockfile --ignore-scripts --loglevel error --prefer-offline

Notes

  • I did not run the full test suite or full build in this branch.

Copilot AI review requested due to automatic review settings March 26, 2026 03:39
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 74177f2511

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to reduce CI warning noise under Node 24, update the pinned @happyvertical/* SDK versions across the workspace, and remove some unused dependencies/tooling.

Changes:

  • Update CI workflows and the shared setup composite action to favor Node 24 JS actions and reduce install-time warning output (including pnpm install --loglevel error).
  • Bump @happyvertical/* versions in the pnpm catalog/overrides and update dependency lists accordingly.
  • Remove @langchain/community from dependency/external lists and adjust package bin entries to use workspace-safe wrappers.

Reviewed changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
vite.config.base.ts Removes @langchain/community from the shared Rollup external list.
pnpm-workspace.yaml Bumps @happyvertical/* catalog versions.
packages/scanner/package.json Changes smrt-scan bin path to ./bin/... and includes bin in published files.
packages/core/vite.config.ts Removes @langchain/community from core Rollup external list.
packages/core/package.json Removes @langchain/community dependency and changes smrt-prebuild bin path to ./bin/... (adds bin to files).
packages/cli/package.json Changes smrt/smrt-cli bin paths to ./bin/... (adds bin to files).
package.json Removes semantic-release tooling devDeps; bumps @happyvertical/* overrides.
.github/workflows/test.yml Sets FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 at workflow level.
.github/workflows/test-suite.yml Sets FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 at workflow level.
.github/workflows/stale-issues.yml Sets FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 at workflow level.
.github/workflows/publish.yml Sets FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 at workflow level.
.github/workflows/publish-dry-run.yml Sets FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 at workflow level.
.github/workflows/on-pull-request.yml Sets FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 at workflow level.
.github/workflows/on-merge-main.yml Sets FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 at workflow level.
.github/workflows/build.yml Sets FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 at workflow level.
.github/actions/setup-environment/action.yml Passes auth + NODE_OPTIONS=--disable-warning=DEP0169 into pnpm steps and installs with --loglevel error.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@willgriffin willgriffin merged commit c5f3097 into main Mar 26, 2026
12 checks passed
@willgriffin willgriffin deleted the codex/ci-warning-audit-sdk-bump branch March 26, 2026 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants