fix: switch to helidon-common-features-codegen for @Features metadata #716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the new helidon-common-features-codegen annotation processor with @Features.* annotations as recommended by Helidon developers. This generates feature-registry.json (new format) instead of feature-metadata.properties, which is the recommended approach for Helidon 4.x and will be required in Helidon 5.x. Changes: * Use @Features.* annotations instead of deprecated @feature * Replace helidon-common-features-processor with codegen * Add helidon-common-features-codegen dependency * Add module mapping in gradle/modules.properties Ref: helidon-io/helidon#10936 Fixes: hiero-ledger/hiero-block-node#1964 Signed-off-by: Ivan Zhuravel <ivanguravel@gmail.com>
Contributor
Author
|
Hello @anthony-swirldslabs @akugal ! Would you mind reviewing these changes ? they are about our previous conversation. |
rbarker-dev
approved these changes
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Use the new helidon-common-features-codegen annotation processor with @Features.* annotations as recommended by Helidon developers.
This generates feature-registry.json (new format) instead of feature-metadata.properties, which is the recommended approach for Helidon 4.x and will be required in Helidon 5.x.
Changes:
Ref: helidon-io/helidon#10936
Fixes: hiero-ledger/hiero-block-node#1964
Related issue(s): hiero-ledger/hiero-block-node#1964
Notes for reviewer:
Used the original approach which is about Helidon developer advice.
Checklist
Verified the build and verified hiero-ledger/hiero-block-node#1964