-
Notifications
You must be signed in to change notification settings - Fork 51
Breaking changes for v5.0.0 release #3211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
fe7fb4a
init commit
zamoore 34e5beb
`HdsAdvancedTableTh` Remove `@isVisuallyHidden` argument (#3210)
zamoore 658dd36
Fix `service` import deprecation (#3181)
zamoore 16aa67f
Remove deprecated `HdsMenuPrimitive` component (#3224)
zamoore 3af1a65
Remove unneeded sass-related dependencies (#3206)
zamoore 95ec1ad
`HdsDropdownListItemInteractive` - Remove deprecated `@text` argumentβ¦
zamoore e9e015a
`HdsSideNav` deprecations (#3230)
zamoore 4e214b4
Update `ember-try` matrix (#3202)
zamoore 550a2b4
Update Ember version compatibility (#3264)
zamoore 163e511
Deprecate `HdsModal` and `HdsFlyout` yielded subcomponents (#3222)
zamoore 49c8640
Remove deprecated `ember-flight-icon` `lazyEmbed` flag (#3272)
zamoore 0f65963
Updated export of icons from Figma (#3269)
hashibot-hds 341a54d
Add changeset for `volume-2` icon rename (#3276)
zamoore 552adad
`ApplicationState` - Remove center alignment rule (#3205)
zamoore b341ddd
Remove incorrect `HdsCard` invocation path (#3275)
zamoore 9648079
Upgrade `ember-a11y-refocus` to `v5.1.0` (#3234)
shleewhite 71c1fc2
Upgrade `ember-stargate` (#3268)
zamoore 6ff60fe
Add `ember-basic-dropdown` as a peer dependency (#3282)
zamoore 2d17a59
Upgrade `@ember/render-modifiers` (#3294)
zamoore c228cfe
Adds a11y guardrails in Dropdown ToggleIcon component
zamoore b2a3485
removed icon button example
zamoore 1da2fcc
rebuilt flight-icons
zamoore 1ad91eb
feat(components): remove `ember-get-config` (#3277)
aklkv 61da8f9
remove temporary README addition
zamoore 69c63fd
removed testing file
zamoore a7964b2
removed deleted components from the deprecation workflow
zamoore e891d23
fixing changeset
zamoore 77dad48
Apply suggestion from @KristinLBradley
zamoore 5568de3
Apply suggestion from @shleewhite
zamoore 6e2b30b
Apply suggestion from @shleewhite
zamoore bb6eef0
Apply suggestion from @KristinLBradley
zamoore 5659f11
removed added commas
zamoore 2214a9f
removed trailing comma
zamoore File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| "@hashicorp/design-system-components": major | ||
| --- | ||
|
|
||
| <!-- START components/flyout --> | ||
| `Flyout` - Removed deprecated `HdsFlyoutHeader`, `HdsFlyoutBody`, `HdsFlyoutDescription`, and `HdsFlyoutFooter` subcomponents. | ||
| <!-- END --> | ||
|
|
||
| <!-- START components/modal --> | ||
| `Modal` - Removed deprecated `HdsModalHeader`, `HdsModalBody`, and `HdsModalFooter` subcomponents. | ||
| <!-- END --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| "@hashicorp/design-system-components": major | ||
| --- | ||
|
|
||
| <!-- START components/dropdown --> | ||
|
|
||
| `Dropdown` - Removed the deprecated `@text` argument from the `HdsDropdownListItemInteractive` component. | ||
|
|
||
| To migrate, run the codemod `v4/dropdown-list-item-interactive` (see [readme file](https://github.com/hashicorp/design-system/tree/main/packages/codemods/transforms/v4/dropdown-list-item-interactive)) | ||
|
|
||
| <!-- END --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| "@hashicorp/design-system-components": major | ||
| --- | ||
|
|
||
| <!-- START components/dropdown --> | ||
|
|
||
| `Dropdown` - Added assertion to the `ToggleIcon` to provide improved developer guidance for the `hasChevron` attribute | ||
|
|
||
| <!-- END --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| "@hashicorp/design-system-components": major | ||
| --- | ||
|
|
||
| <!-- START components/form/super-select --> | ||
|
|
||
| Added `ember-basic-dropdown` as a peer dependency required by `ember-power-select`. To migrate, if your application uses `SuperSelect`, make sure to add this dependency. | ||
zamoore marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| <!-- END --> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| "@hashicorp/design-system-components": major | ||
| --- | ||
|
|
||
| <!-- START components/application-state --> | ||
|
|
||
| `ApplicationState` - Replaced the default opinionated `margin: 0 auto;` rule from the component's root element with a new `@isAutoCentered` argument (which defaults to `true`, to preserve the existing centering behavior). This delegates the horizontal alignment control to the consumers, allowing them to disable it when needed. | ||
| <!-- END --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@hashicorp/design-system-components": major | ||
| --- | ||
|
|
||
| Removed support for Ember 3.28. New minimum support target is Ember 4.12. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@hashicorp/design-system-components": major | ||
| --- | ||
|
|
||
| Removed `sass` and `ember-cli-sass` dependencies. Consumers using `sass` in their projects should make sure it's added as a direct dependency to their project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| "@hashicorp/design-system-components": major | ||
| --- | ||
|
|
||
| <!-- START components/table/advanced-table --> | ||
| `AdvancedTable` - Removed the `@isVisuallyHidden` argument from `HdsAdvancedTableTh` component. This setting is supported via setting `isVisuallyHidden` in the corresponding `@columns` item's configuration. | ||
| <!-- END --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| "@hashicorp/design-system-components": patch | ||
| --- | ||
|
|
||
| <!-- START components/side-nav --> | ||
| `SideNav` - Fixed the type of `@a11yRefocusRouteChangeValidator` to match the expected type from `ember-a11y-refocus`. The new type is `(transition: Transition) => boolean` instead of `string`. | ||
| <!-- END --> | ||
|
|
||
| <!-- START components/app-header --> | ||
| `AppHeader` - Fixed the type of `@a11yRefocusRouteChangeValidator` to match the expected type from `ember-a11y-refocus`. The new type is `(transition: Transition) => boolean` instead of `string`. | ||
| <!-- END --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@hashicorp/design-system-components": major | ||
| --- | ||
|
|
||
| Removed the deprecated `MenuPrimitive` component |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "@hashicorp/design-system-components": major | ||
| --- | ||
|
|
||
| Upgraded `ember-a11y-refocus` dependency to version `5.0` | ||
| Upgraded `@glimmer/component` dependency to version `2.0` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "@hashicorp/design-system-components": major | ||
| --- | ||
| <!-- START components/card --> | ||
| `Card` - Removed the component invocation paths `Hds::Card` and `hds/card`. Consumers must update their templates to use `<Hds::Card::Container>` or `{{hds/card/container}}` | ||
| <!-- END --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@hashicorp/flight-icons": major | ||
| --- | ||
|
|
||
| Renamed `volume-2` to `volume-up`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| --- | ||
| "@hashicorp/design-system-components": major | ||
| --- | ||
|
|
||
| <!-- START components/side-nav --> | ||
| `SideNav` - Removed deprecated features | ||
| - Removed the `@ariaLabel` argument | ||
| - Removed the `HdsSideNavHeaderIconButton` component | ||
| - Updated the deprecation removal version from `5.0.0` to `6.0.0` | ||
| <!-- END --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| "@hashicorp/design-system-components": major | ||
| --- | ||
|
|
||
| <!-- START components/icon --> | ||
| `Icon` - Renamed the `volume-2` icon to `volume-up` | ||
| <!-- END --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@hashicorp/design-system-components": major | ||
| --- | ||
|
|
||
| Removed support for deprecated `ember-flight-icons` `lazyEmbed` config |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.