Conversation
tgross
force-pushed
the
gh341-keyring-lock
branch
3 times, most recently
from
6a5868e to
f435b01
Compare
The keyring has several data races between its public methods where we read from or iterate over the keyring without taking the mutex. A concurrent `AddKey`, `RemoveKey`, or `UseKey` call can write to the location being read. Move some of the data read functions into private methods that expect the lock to be held, and hold that lock in the public methods. Fixes: #341
tgross
force-pushed
the
gh341-keyring-lock
branch
from
f435b01 to
47c31d9
Compare
dxasu
approved these changes
Jan 20, 2026
sonamtenzin2
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The keyring has several data races between its public methods where we read from or iterate over the keyring without taking the mutex. A concurrent
AddKey,RemoveKey, orUseKeycall can write to the location being read.Move some of the data read functions into private methods that expect the lock to be held, and hold that lock in the public methods.
Fixes: #341
Description
Related Issue
How Has This Been Tested?