feat: improve error experience, linting, and more #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Liam Stanley <me@liamstanley.io>
- migrated away from ioutil as it's been deprecated since go 1.16 - also believe this fixes a few cases of unhandled errors - added golangci-lint config Signed-off-by: Liam Stanley <me@liamstanley.io>
Signed-off-by: Liam Stanley <me@liamstanley.io>
|
|
This was referenced Aug 12, 2022
|
Any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This PR has quite a few error related improvements, as well as fixes recommended from golangci-lint. If you'd like me to move the lint related fixes into another PR, I can do that as well.
List of changes:
tfexecto redirectstderrreturned from the terraform CLI, back to the user. This will give context to errors like "configuration is invalid" where you can't tell what the error is.io/ioutilas it has been deprecated since Go 1.16..golang-ci.yml), which will help with Addgolangci-lintconfiguration and PR workflow GH Actions #144.If there are any adjustments you'd like me to make, I'd be happy to!