r/aws_observabilityadmin_centralization_rule_for_organization #44806

bonclay7 · 2025-10-25T16:42:54Z

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

No

Description

This implements a centralization rule in an AWS Org for telemetry data

Relations

Relates #44651

Output from Acceptance Testing

%  make testacc TESTARGS='-run=TestAccObservabilityAdminCentralizationRuleForOrganization' PKG=observabilityadmin ACCTEST_PARALLELISM=5
make: Fixing source code with gofmt...
gofmt -s -w ./internal ./names ./.ci/providerlint/helper ./.ci/providerlint/main.go ./.ci/providerlint/passes
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Building provider...
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-observabilityadmin_centralization_rule_for_organization 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/observabilityadmin/... -v -count 1 -parallel 5  -run=TestAccObservabilityAdminCentralizationRuleForOrganization -timeout 360m -vet=off
2025/10/31 20:47:42 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/31 20:47:42 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccObservabilityAdminCentralizationRuleForOrganization_basic
=== PAUSE TestAccObservabilityAdminCentralizationRuleForOrganization_basic
=== RUN   TestAccObservabilityAdminCentralizationRuleForOrganization_disappears
=== PAUSE TestAccObservabilityAdminCentralizationRuleForOrganization_disappears
=== RUN   TestAccObservabilityAdminCentralizationRuleForOrganization_update
=== PAUSE TestAccObservabilityAdminCentralizationRuleForOrganization_update
=== RUN   TestAccObservabilityAdminCentralizationRuleForOrganization_import
=== PAUSE TestAccObservabilityAdminCentralizationRuleForOrganization_import
=== CONT  TestAccObservabilityAdminCentralizationRuleForOrganization_basic
=== CONT  TestAccObservabilityAdminCentralizationRuleForOrganization_update
=== CONT  TestAccObservabilityAdminCentralizationRuleForOrganization_import
=== CONT  TestAccObservabilityAdminCentralizationRuleForOrganization_disappears
--- PASS: TestAccObservabilityAdminCentralizationRuleForOrganization_disappears (32.18s)
--- PASS: TestAccObservabilityAdminCentralizationRuleForOrganization_basic (37.74s)
--- PASS: TestAccObservabilityAdminCentralizationRuleForOrganization_import (38.02s)
--- PASS: TestAccObservabilityAdminCentralizationRuleForOrganization_update (79.55s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/observabilityadmin	81.711s

github-actions · 2025-10-25T16:43:10Z

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

github-actions · 2025-10-25T16:43:13Z

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
Please see our prioritization guide for additional information on how the maintainers handle prioritization.
Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

bonclay7 · 2025-10-31T22:31:51Z

% make testacc TESTARGS='-run=TestAccObservabilityAdminCentralizationRuleForOrganization' PKG=observabilityadmin ACCTEST_PARALLELISM=5
make: Fixing source code with gofmt...
gofmt -s -w ./internal ./names ./.ci/providerlint/helper ./.ci/providerlint/main.go ./.ci/providerlint/passes
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Building provider...
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-observabilityadmin_centralization_rule_for_organization 🌿...
TF_ACC=1 go1.24.8 test ./internal/service/observabilityadmin/... -v -count 1 -parallel 5  -run=TestAccObservabilityAdminCentralizationRuleForOrganization -timeout 360m -vet=off
2025/10/31 22:22:19 Creating Terraform AWS Provider (SDKv2-style)...
2025/10/31 22:22:19 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccObservabilityAdminCentralizationRuleForOrganization_basic
=== PAUSE TestAccObservabilityAdminCentralizationRuleForOrganization_basic
=== RUN   TestAccObservabilityAdminCentralizationRuleForOrganization_disappears
=== PAUSE TestAccObservabilityAdminCentralizationRuleForOrganization_disappears
=== RUN   TestAccObservabilityAdminCentralizationRuleForOrganization_update
=== PAUSE TestAccObservabilityAdminCentralizationRuleForOrganization_update
=== CONT  TestAccObservabilityAdminCentralizationRuleForOrganization_basic
=== CONT  TestAccObservabilityAdminCentralizationRuleForOrganization_update
=== CONT  TestAccObservabilityAdminCentralizationRuleForOrganization_disappears
--- PASS: TestAccObservabilityAdminCentralizationRuleForOrganization_disappears (29.13s)
--- PASS: TestAccObservabilityAdminCentralizationRuleForOrganization_basic (35.26s)
--- PASS: TestAccObservabilityAdminCentralizationRuleForOrganization_update (74.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/observabilityadmin	77.108s

…eouts.

…onal plan-time validations.

…onal acceptance test pre-checks.

…or the rule to become healthy.

% make testacc TESTARGS='-run=TestAccObservabilityAdminCentralizationRuleForOrganization_basic' PKG=observabilityadmin make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... make: Running acceptance tests on branch: 🌿 HEAD 🌿... TF_ACC=1 go1.24.10 test ./internal/service/observabilityadmin/... -v -count 1 -parallel 20 -run=TestAccObservabilityAdminCentralizationRuleForOrganization_basic -timeout 360m -vet=off 2025/11/10 16:31:33 Creating Terraform AWS Provider (SDKv2-style)... 2025/11/10 16:31:33 Initializing Terraform AWS Provider (SDKv2-style)... === RUN TestAccObservabilityAdminCentralizationRuleForOrganization_basic === PAUSE TestAccObservabilityAdminCentralizationRuleForOrganization_basic === CONT TestAccObservabilityAdminCentralizationRuleForOrganization_basic --- PASS: TestAccObservabilityAdminCentralizationRuleForOrganization_basic (19.71s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/observabilityadmin 25.386s

…estAccObservabilityAdminCentralizationRuleForOrganization_tags'.

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccObservabilityAdminCentralizationRuleForOrganization_' PKG=observabilityadmin ACCTEST_PARALLELISM=2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 HEAD 🌿...
TF_ACC=1 go1.24.10 test ./internal/service/observabilityadmin/... -v -count 1 -parallel 2  -run=TestAccObservabilityAdminCentralizationRuleForOrganization_ -timeout 360m -vet=off
2025/11/11 09:53:01 Creating Terraform AWS Provider (SDKv2-style)...
2025/11/11 09:53:01 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccObservabilityAdminCentralizationRuleForOrganization_basic
=== PAUSE TestAccObservabilityAdminCentralizationRuleForOrganization_basic
=== RUN   TestAccObservabilityAdminCentralizationRuleForOrganization_disappears
=== PAUSE TestAccObservabilityAdminCentralizationRuleForOrganization_disappears
=== RUN   TestAccObservabilityAdminCentralizationRuleForOrganization_update
=== PAUSE TestAccObservabilityAdminCentralizationRuleForOrganization_update
=== RUN   TestAccObservabilityAdminCentralizationRuleForOrganization_tags
=== PAUSE TestAccObservabilityAdminCentralizationRuleForOrganization_tags
=== CONT  TestAccObservabilityAdminCentralizationRuleForOrganization_basic
=== CONT  TestAccObservabilityAdminCentralizationRuleForOrganization_update
--- PASS: TestAccObservabilityAdminCentralizationRuleForOrganization_basic (20.06s)
=== CONT  TestAccObservabilityAdminCentralizationRuleForOrganization_disappears
--- PASS: TestAccObservabilityAdminCentralizationRuleForOrganization_disappears (14.82s)
=== CONT  TestAccObservabilityAdminCentralizationRuleForOrganization_tags
--- PASS: TestAccObservabilityAdminCentralizationRuleForOrganization_update (44.13s)
--- PASS: TestAccObservabilityAdminCentralizationRuleForOrganization_tags (41.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/observabilityadmin	82.352s

YakDriver

LGTM 🎉

ewbankkit · 2025-11-11T16:41:32Z

@bonclay7 Thanks for the contribution 🎉 👏.

github-actions · 2025-11-11T16:41:49Z

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

github-actions · 2025-11-13T20:44:18Z

This functionality has been released in v6.21.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Add initial resource

75bdaab

bonclay7 requested a review from a team as a code owner October 25, 2025 16:42

bonclay7 marked this pull request as draft October 25, 2025 16:43

justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 28, 2025

bonclay7 added 2 commits October 29, 2025 13:51

Fix schema conversion errors

4b7e756

Remove status as APIs are sync

572d86d

github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Oct 29, 2025

bonclay7 added 9 commits October 30, 2025 09:54

Fix drift detection

11918f1

Update identifier: make gen

ba787c0

Update acceptance tests

9fc4fa3

Fix tests

34a630f

Add changelog

9202148

Add tags

9fb0d31

Add docs

77eac71

Fix linting

c50ce33

Drop dead code

dc56c40

github-actions bot added documentation Introduces or discusses updates to documentation. tags Pertains to resource tagging. labels Oct 31, 2025

Fix CI tests

45a5343

bonclay7 marked this pull request as ready for review October 31, 2025 21:42

Merge branch 'main' into HEAD

aca6303

ewbankkit added 5 commits November 10, 2025 14:41

r/aws_observabilityadmin_centralization_rule_for_organization: No tim…

af3d50c

…eouts.

r/aws_observabilityadmin_centralization_rule_for_organization: Additi…

3d26bb6

…onal plan-time validations.

r/aws_observabilityadmin_centralization_rule_for_organization: Additi…

b9622a8

…onal acceptance test pre-checks.

r/aws_observabilityadmin_centralization_rule_for_organization: Wait f…

887bf59

…or the rule to become healthy.

ewbankkit self-assigned this Nov 11, 2025

github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 11, 2025

ewbankkit added 3 commits November 11, 2025 09:47

Add 'acctest.ListOfStrings'.

8951e36

r/aws_observabilityadmin_centralization_rule_for_organization: Add 'T…

1b3baf6

…estAccObservabilityAdminCentralizationRuleForOrganization_tags'.

Merge branch 'main' into HEAD

dd76613

ewbankkit previously approved these changes Nov 11, 2025

View reviewed changes

ewbankkit added 2 commits November 11, 2025 10:58

Run 'make fix-constants PKG=observabilityadmin'.

ebc453b

Fix golangci-lint 'unparam'.

34dae51

ewbankkit dismissed their stale review via 34dae51 November 11, 2025 15:59

YakDriver approved these changes Nov 11, 2025

View reviewed changes

ewbankkit merged commit 3c668de into hashicorp:main Nov 11, 2025
43 checks passed

github-actions bot added this to the v6.21.0 milestone Nov 11, 2025

bonclay7 deleted the f-observabilityadmin_centralization_rule_for_organization branch November 12, 2025 08:29

bonclay7 restored the f-observabilityadmin_centralization_rule_for_organization branch November 12, 2025 08:29

bonclay7 deleted the f-observabilityadmin_centralization_rule_for_organization branch November 12, 2025 08:30

github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

r/aws_observabilityadmin_centralization_rule_for_organization #44806

r/aws_observabilityadmin_centralization_rule_for_organization #44806

Uh oh!

bonclay7 commented Oct 25, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 25, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 25, 2025

Uh oh!

bonclay7 commented Oct 31, 2025

Uh oh!

ewbankkit left a comment

Uh oh!

YakDriver left a comment

Uh oh!

ewbankkit commented Nov 11, 2025

Uh oh!

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

github-actions bot commented Nov 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

r/aws_observabilityadmin_centralization_rule_for_organization #44806

r/aws_observabilityadmin_centralization_rule_for_organization #44806

Uh oh!

Conversation

bonclay7 commented Oct 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rollback Plan

Changes to Security Controls

Description

Relations

Output from Acceptance Testing

Uh oh!

github-actions bot commented Oct 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 25, 2025

Community Guidelines

Voting for Prioritization

Pull Request Authors

Uh oh!

bonclay7 commented Oct 31, 2025

Uh oh!

ewbankkit left a comment

Choose a reason for hiding this comment

Uh oh!

YakDriver left a comment

Choose a reason for hiding this comment

Uh oh!

ewbankkit commented Nov 11, 2025

Uh oh!

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

github-actions bot commented Nov 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bonclay7 commented Oct 25, 2025 •

edited

Loading

github-actions bot commented Oct 25, 2025 •

edited

Loading