-
Notifications
You must be signed in to change notification settings - Fork 116
Optimizing build cache step #1395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
ac73a17
updating build preview step to not be so ridiculously expensive
williamdalessandro 2ba839e
adding the same optimization to the deploy-udr step
williamdalessandro d6ac7c9
testing this
williamdalessandro 48f7444
change to pull_request
williamdalessandro f295eae
Revert "testing this"
williamdalessandro 87be935
Merge branch 'main' into optimizing-build-cache-step
williamdalessandro 5a0637f
adding future testing instructions and massively simplfying/fixing th…
williamdalessandro 6e820f2
test
williamdalessandro dd95fc8
updating the nextjs cache step with at the deploy udr step
williamdalessandro 2ce8e29
Merge branch 'main' into optimizing-build-cache-step
williamdalessandro 95a8dc7
testing to see if this makes any more of a difference
williamdalessandro 8427a60
test
williamdalessandro ad4da6f
changing to ci for very small potential time saves
williamdalessandro 864745f
Revert "changing to ci for very small potential time saves"
williamdalessandro f04aa89
Reapply "changing to ci for very small potential time saves"
williamdalessandro f039734
Merge branch 'main' into optimizing-build-cache-step
williamdalessandro 5c474ec
updating binaries
williamdalessandro 05b9db8
changing back to pr target
williamdalessandro 5013c5e
binaries conflict
williamdalessandro 2a51dd1
Merge branch 'main' into optimizing-build-cache-step
williamdalessandro a77c3b9
updating binaries again
williamdalessandro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Return to testing if this is dependent on local machines thread count? Could this cause CPU thread switching trash?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only unknown here, but really don't know. 🤷🏻
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since it's node and its batching promises, there's inherent protection against that because its limited to 4 threads based on the UV_THREADPOOL_SIZE parameter. So it's always handling 4 things at a time, but we'd just be handing it a bigger batch that's a bit more efficient, but also not going so crazy with the batch size that we hit other issues with memory pressure. So it should be fine to stay