Skip to content

Add json-file option#57

Open
9999years wants to merge 3 commits intohaskell-actions:mainfrom
9999years:json-file
Open

Add json-file option#57
9999years wants to merge 3 commits intohaskell-actions:mainfrom
9999years:json-file

Conversation

@9999years
Copy link
Copy Markdown

@9999years 9999years commented Mar 27, 2024

Adds a json-file option which consumes output from a previous hlint --json run.

@9999years 9999years marked this pull request as ready for review March 28, 2024 15:53
Copy link
Copy Markdown
Member

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain what this PR aims to bring? What is the use case?

Also, it would be ideal if this PR focuses only on what it sets up to do. Right now, you also have changes on newlines escapes, which I think should be in a separate PR with its own justification

@9999years
Copy link
Copy Markdown
Author

Sure! We use nix to package and run hlint, so there's not an hlint executable on the $PATH. We have hlint output JSON itself, and then we pass it through to this Action. Does that make sense? Happy to split the newline escape changes into another PR. (I'm picking this change up from the colleague that originally wrote it.)

@mihaimaruseac
Copy link
Copy Markdown
Member

Sorry, I completely forgot about this. Yes please, let's split the newline change to another PR.

As a side note, I'm considering deprecating hlint-{setup,run} pair in favor of https://github.com/haskell-actions/hlint-scan but I need to make sure all current users can migrate without being impacted too severely. Can you please take a look and see if you can use hlint-scan instead? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants