Add Hint: getFileStatus and getSymbolicLinkStatus #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bodigrim
reviewed
Oct 7, 2025
Contributor
Author
|
During my research to the causes of this, I have noticed that there is no support for the |
Bodigrim
reviewed
Oct 9, 2025
Bodigrim
reviewed
Oct 9, 2025
Contributor
|
CC @hs-viktor @hasufell for review. |
Member
|
@Hyalunar can you fix the remaining issues? |
vdukhovni
suggested changes
Oct 14, 2025
Co-authored-by: Viktor Dukhovni <viktor1ghub@dukhovni.org>
Co-authored-by: Viktor Dukhovni <viktor1ghub@dukhovni.org>
Co-authored-by: Viktor Dukhovni <viktor1ghub@dukhovni.org>
Contributor
Author
|
I have removed the platform-specific hints and checked that the documentation for |
hasufell
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users have repeatedly tripped over the subtle difference between
getFileStatusandgetSymbolicLinkStatus.I have added a single line of documentation to hint at the other function. Currently there is only a hint in
getSymbolicLinkStatus.I'm not sure whether this is enough to stop these mix-ups from happening, but I didn't want to make all the documentation of
getFileStatusaboutgetSymbolicLinkStatus.Looking forward to hearing from you
My thanks go to the discourse user f-a for encouraging me to open up an issue/PR.