Sign In With Ethereum authentication strategy#437
Open
austinbuckler wants to merge 18 commits intohathora:developfrom
Open
Sign In With Ethereum authentication strategy#437austinbuckler wants to merge 18 commits intohathora:developfrom
austinbuckler wants to merge 18 commits intohathora:developfrom
Conversation
feat: added chat-siwe example for sign-in with ethereum.
Component and type for UserData.
hpx7
requested changes
Feb 5, 2023
Member
hpx7
left a comment
There was a problem hiding this comment.
Mostly looks great, thanks!
Two requests:
- Can we rename
siwetoetherum? - Can we get rid of the new example app and instead add
etherumas an auth option to an existing app (probably chat)?
I think we should stick with the nomenclature for siwe as people that will likely leverage this in the crypto-space will be familiar with the terminology. And yes I can refactor the example to be used in the chat example. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the example auth server: https://github.com/lionhat-collective/hathora-siwe-auth-example