Skip to content

Fix compile time errors for gcc15 and restructure CMakeLists files#64

Open
YanzhaoW wants to merge 8 commits intohdtv-tool:masterfrom
YanzhaoW:compile
Open

Fix compile time errors for gcc15 and restructure CMakeLists files#64
YanzhaoW wants to merge 8 commits intohdtv-tool:masterfrom
YanzhaoW:compile

Conversation

@YanzhaoW
Copy link

@YanzhaoW YanzhaoW commented Jan 29, 2026

  • Fix compile time errors due to the usage of old prototype function pointers.
  • Ignore compile warnings due to the function pointer casting.
  • Restructure CMakeLists:
    • Use FILE_SET for cmake targets.
    • Use MODULE parameter to generate ROOT dictionary from a cmake target.
    • Create RPATH to establish correct linkage between share libraries.
    • Remove old ROOT macros for dictionary generations.
    • Put C code into different targets and link them to the CXX code dynamically.
    • Remove unnecessary INSTALL destinations.
  • Disable python warnings from uncertainties, due to std_dev ==0.
  • Change the message regarding the history file not present or read only.

The PR branch is used to build docker images of hdtv. Instructions and the Dockerfile can be seen here.

@heijligen
Copy link
Contributor

Hi, thank you for your contribution.
We have currently some PRs dealing the with same issues: Can you have a look if #56 or #57 solves your problem with building libmfile? Furthermore PR #53 removes all C code of matop and PR #58 fixes issues with the docker container and fixes the exit of hdtv after a --rebuild-sys or --rebuild-usr.

You added a environment.yaml, what is it for?

I'll have a look at your docker setup. Thanks

@YanzhaoW
Copy link
Author

YanzhaoW commented Jan 29, 2026

Hi. Sorry that I didn't see there are already some fixes in open PRs. I will rebase them when they are merged.

Can you have a look if #56 or #57 solves your problem with building libmfile?

Yes, I think this fixes the compile errors.

You added a environment.yaml, what is it for?

Ah, that's for conda environment. I'm using miniforge/conda to deal with the python virtual environment and this file helps me to create an environment with all packages needed for hdtv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants