Edited the email regex in config/initializers to remove a multiline a…#5723
Open
mikeh-dev wants to merge 1 commit intoheartcombo:mainfrom
Open
Edited the email regex in config/initializers to remove a multiline a…#5723mikeh-dev wants to merge 1 commit intoheartcombo:mainfrom
mikeh-dev wants to merge 1 commit intoheartcombo:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Environment
Ruby 3.1.2
Rails 7.0.7
Devise 4.9.4
Current behaviour
I ran into a failing test with Rspec on the valid email check
The original regex here;
config.email_regexp =/^([\w.%+-]+)@([\w-]+.)+([\w]{2,})$/i
was failing on a new line error
Solution
I corrected to
/\A([\w.%+-]+)@([\w-]+.)+([\w]{2,})\z/i
Basically the same but changing the start and end removed the multiline anchors error for me.
OLD uses ^ and $: Matches start/end of any line
NEW uses \A and \z: Matches start/end of entire string