Skip to content

Add sanitization to the passwords controller #5749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hakeem0114 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add sanitization to the passwords controller #5749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/controllers/devise/passwords_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,4 +80,8 @@ def unlockable?(resource)
def translation_scope
'devise.passwords'
end

def resource_params
devise_parameter_sanitizer.sanitize(:reset_password)
end
end
3 changes: 2 additions & 1 deletion lib/devise/parameter_sanitizer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ class ParameterSanitizer
DEFAULT_PERMITTED_ATTRIBUTES = {
sign_in: [:password, :remember_me],
sign_up: [:password, :password_confirmation],
account_update: [:password, :password_confirmation, :current_password]
account_update: [:password, :password_confirmation, :current_password],
reset_password: [:reset_password_token, :password, :password_confirmation]
}

def initialize(resource_class, resource_name, params)
Expand Down
7 changes: 7 additions & 0 deletions test/parameter_sanitizer_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,13 @@ def sanitizer(params)
assert_equal({ 'email' => 'jose' }, sanitized)
end

test 'permits the default parameters for password reset' do
sanitizer = sanitizer('user' => { 'email' => 'jose', 'password' => 'myPassword1234', 'role' => 'invalid' })
sanitized = sanitizer.sanitize(:reset_password)

assert_equal({ 'email' => 'jose', 'password' => 'myPassword1234' }, sanitized)
end

test 'permits news parameters for an existing action' do
sanitizer = sanitizer('user' => { 'username' => 'jose' })
sanitizer.permit(:sign_in, keys: [:username])
Expand Down