Tell the recipient software when a password link expires.#5785
Open
arnt wants to merge 1 commit intoheartcombo:mainfrom
Open
Tell the recipient software when a password link expires.#5785arnt wants to merge 1 commit intoheartcombo:mainfrom
arnt wants to merge 1 commit intoheartcombo:mainfrom
Conversation
|
+1 |
Author
|
Huh, I didn't see any checklist when I originally made the PR? But it ① follows the code style (and what a nice style it is, too), ② adds tests and ③ contains no breaking changes. |
Author
|
FWIW, Thunderbird just got an implementation of this. It can now archive messages automatically when (in Devise's case) the password link grows stale, or even delete the messages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://datatracker.ietf.org/doc/draft-ietf-mailmaint-expires/
That draft documents the (rare) existing usage of the Expires field, specifies a tighter syntax, and clarifies that "expires" doesn't mean having to delete anything. "Automatically moving the message from inbox to archive" is sensible.
The IETF mailmaint WG requires two implementations before issuing an RFC. I did this one today, to see how hard it would be.
(Or maybe the true reason is: I searched my mail today for a particular domain and and saw several old password reset messages among the top search results. That's junk, those links are expired, let's tell the mailbox indexer when those messages become poor search results.)
It seems reasonable to extend it to cover confirmation messages too.