feat: Allow computed method for To header in mailers#5793
Open
boypie510 wants to merge 1 commit intoheartcombo:mainfrom
Open
feat: Allow computed method for To header in mailers#5793boypie510 wants to merge 1 commit intoheartcombo:mainfrom
boypie510 wants to merge 1 commit intoheartcombo:mainfrom
Conversation
boypie510
commented
Aug 16, 2025
Comment on lines
-43
to
-44
| assert mail.from, "from@example.com" | ||
| assert mail.reply_to, "reply_to@example.com" |
Author
There was a problem hiding this comment.
https://docs.ruby-lang.org/en/2.1.0/Test/Unit/Assertions.html
These assertions will ALWAYS pass
assert mail.from - checks if mail.from is truthy (which it always is)
"from@example.com" - this second argument is completely ignored
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for computed
Toheader in Devise mailers, allowing users to customize the recipient field usingdefault :todeclarations, similar to howfromandreply_toalready work.Problem
Currently, Devise hardcodes the
tofield toresource.emailand doesn't respect customdefault :tovalues set in mailer classes. This prevents users from:tofield like other mailer headersSolution
Add a single line to check
default_params[:to]in theheaders_formethod:This follows the same pattern already used for
fromandreply_tofields.Example Usage
Related Issues
Fixes the issue described in: Allow providing computed method for To header
Checklist