Fix password_length for new generated templates and default due to bcrypt gem work#5806
Open
le0pard wants to merge 1 commit intoheartcombo:mainfrom
Open
Fix password_length for new generated templates and default due to bcrypt gem work#5806le0pard wants to merge 1 commit intoheartcombo:mainfrom
le0pard wants to merge 1 commit intoheartcombo:mainfrom
Conversation
3865a95 to
0fc0693
Compare
0fc0693 to
b4e347c
Compare
Author
|
It is ready for review @carlosantoniodasilva Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More info: bcrypt-ruby/bcrypt-ruby#283
Reproduction:
All return true, so
Password 1:
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa1Password 2:
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa2These two users can login to each other's accounts because brcypt caps hashing to the first 72 bytes
not needed, if #5807 merged