Fix optional PCB commands in rules not taking effect on ESP32#856
Closed
IgorYbema wants to merge 1 commit intoheishamon:mainfrom
Closed
Fix optional PCB commands in rules not taking effect on ESP32#856IgorYbema wants to merge 1 commit intoheishamon:mainfrom
IgorYbema wants to merge 1 commit intoheishamon:mainfrom
Conversation
On ESP32 the periodic optional PCB send runs in a FreeRTOS task that reads exclusively from pcbQueue via xQueuePeek. When a rule executed an optional PCB command (e.g. @SetZ2WaterTemp = 45), set_xxx_temp() correctly updated optionalPCBQuery but never wrote the new value to pcbQueue, so the task kept sending stale data indefinitely. The MQTT path (send_heatpump_command) already called xQueueOverwrite after invoking the command function. Apply the same fix in vm_value_set so rules have the same behaviour. On ESP8266 the periodic send reads optionalPCBQuery directly, so no change in behaviour there. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On ESP32 the periodic optional PCB send runs in a FreeRTOS task that reads exclusively from pcbQueue via xQueuePeek. When a rule executed an optional PCB command (e.g. @SetZ2WaterTemp = 45), set_xxx_temp() correctly updated optionalPCBQuery but never wrote the new value to pcbQueue, so the task kept sending stale data indefinitely.
The MQTT path (send_heatpump_command) already called xQueueOverwrite after invoking the command function. Apply the same fix in vm_value_set so rules have the same behaviour.
On ESP8266 the periodic send reads optionalPCBQuery directly, so no change in behaviour there.