Open
Conversation
fv17
reviewed
Dec 11, 2025
| sum += l2->val; | ||
| l2 = l2->next; | ||
| } | ||
| curr->next = new ListNode(sum % 10); |
There was a problem hiding this comment.
curr という名前から現在操作中の桁(ノード)を表すものだなと判断する読み手が多い気がします。
しかし、書いていただいたコードでは操作中の桁を curr そのものではなく next に代入していることが少し気になりました。
Owner
Author
There was a problem hiding this comment.
たしかにdummyをListNode(0)で作って、最終的にdummy->nextを返している都合上curr->nextに操作した桁を代入していますが、prevみたいな名前にするのも変な気がして難しいですね。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
この問題:https://leetcode.com/problems/add-two-numbers/description/
次に解く問題:https://leetcode.com/problems/valid-parentheses/description/