Open
Conversation
t9a-dev
reviewed
Dec 15, 2025
| class KthLargest { | ||
| public: | ||
| priority_queue<int, vector<int>, greater<int>> kth_largest; | ||
| int K; |
There was a problem hiding this comment.
メンバ名のKが気になりました。大文字なので定数に見えたという感覚です。特に理由がなければ、Google C++ Style Guideなどを参考にk_にするかなと思いました。
https://google.github.io/styleguide/cppguide.html#Variable_Names
Suggested change
| int K; | |
| int k_; |
oda
reviewed
Dec 16, 2025
Comment on lines
+8
to
+11
| kth_largest.push(num); | ||
| if (kth_largest.size() > K) { | ||
| kth_largest.pop(); | ||
| } |
| @@ -0,0 +1,11 @@ | |||
| ### step1 | |||
|
|
|||
| 値の小さい順のpriority queueにk個の要素を入れておいて、top()でk番目に大きい要素を返すというやり方を思いついて実装したが、細かい部分がちゃんと実装できていなかったのでGPTにスッキリ書き直してもらった。 | |||
There was a problem hiding this comment.
私はむしろこちらのほうがいいくらいの気持ちですね。無駄な push pop がないので。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
この問題：https://leetcode.com/problems/kth-largest-element-in-a-stream/description/
次に解く問題：https://leetcode.com/problems/top-k-frequent-elements/description/