fix: use the upstream interface name#31
Conversation
The commit revision naming seems to have been introduced by proton-api-bridge in a custom fork simply due to their personal preferences regarding the API call. This name change functionally breaks backwards compatibility with the upstream proton-go-api, as well as any other tools using proton-go-api. Such breaking changes need to be justified and can not simply be a matter of naming preferences.
|
Hey @major0, Thanks for creating this PR! Based on my vague memory, this was likely due to missing implementation / field of the entire Drive-related functionality at the time, so I took the naming from iOS codebase (as it was the source of truth at the time). I will look into reverting this naming change since the field included in Have you run the integration test on your side after making this change? :) |
|
The commit revision naming seems to have been introduced by proton-api-bridge in a custom fork simply due to their personal preferences regarding the API call. This name change functionally breaks backwards compatibility with the upstream proton-go-api, as well as any other tools using proton-go-api. Such breaking changes need to be justified and can not simply be a matter of naming preferences.