Skip to content
This repository was archived by the owner on Feb 5, 2026. It is now read-only.

fix: use the upstream interface name#31

Open
major0 wants to merge 1 commit intohenrybear327:masterfrom
major0:fix/update_revision
Open

fix: use the upstream interface name#31
major0 wants to merge 1 commit intohenrybear327:masterfrom
major0:fix/update_revision

Conversation

@major0
Copy link
Contributor

@major0 major0 commented Jan 16, 2025

The commit revision naming seems to have been introduced by proton-api-bridge in a custom fork simply due to their personal preferences regarding the API call. This name change functionally breaks backwards compatibility with the upstream proton-go-api, as well as any other tools using proton-go-api. Such breaking changes need to be justified and can not simply be a matter of naming preferences.

The commit revision naming seems to have been introduced by
proton-api-bridge in a custom fork simply due to their personal
preferences regarding the API call. This name change functionally breaks
backwards compatibility with the upstream proton-go-api, as well as any
other tools using proton-go-api. Such breaking changes need to be
justified and can not simply be a matter of naming preferences.
@henrybear327
Copy link
Owner

Hey @major0,

Thanks for creating this PR!

Based on my vague memory, this was likely due to missing implementation / field of the entire Drive-related functionality at the time, so I took the naming from iOS codebase (as it was the source of truth at the time).

I will look into reverting this naming change since the field included in UpdateRevisionReq is a bit different from CommitRevisionReq, so I am not sure if these are the exact same struct!

Have you run the integration test on your side after making this change? :)

@major0
Copy link
Contributor Author

major0 commented Feb 21, 2025

I will look into reverting this naming change since the field included in UpdateRevisionReq is a bit different from CommitRevisionReq, so I am not sure if these are the exact same struct!

Have you run the integration test on your side after making this change? :)
Nope, I just went straight into writing a proton-cli... which .. has worked pretty well so far honestly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants