This repository was archived by the owner on Oct 16, 2024. It is now read-only.
Treat any <a class="facebook-button">...</a> as a generic button.#14
Open
fabacab wants to merge 1 commit intoheroku:masterfrom
Open
Treat any <a class="facebook-button">...</a> as a generic button.#14fabacab wants to merge 1 commit intoheroku:masterfrom
<a class="facebook-button">...</a> as a generic button.#14fabacab wants to merge 1 commit intoheroku:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch allows app developers to use HTML like
<a href="…" class="facebook-button">…</a>to create a generic button. Previously, for button-like spacing, there needed to be a<span>that also had to have one of three classes that matched a sprite image. This is awkward in cases where the sprite images don't really match the button functionality. For instance, the HTML to implement a logout button might look like<a href="<?php print $FB->getLogoutUrl();?>" class="facebook-button"><span>Log out of Facebook</span></a>, but this would result in a "speech bubble" icon appearing next to the "log out" button. Dropping the<span>and applying the generic spacing CSS to thefacebook-buttonclass directly is clearer and more semantically appropriate.