Transition-specific costs and cCTSTMs#123
Open
mclements wants to merge 30 commits intohesim-dev:mainfrom
Open
Conversation
Collaborator
Author
|
I have added some changes to address the recent R check notes and warnings:
|
This needs a size attribute
Collaborator
Author
|
Devin: pkgdown is complaining about the documentation for CohortCtstm in ctstm.R. I can't see the error - would you be able to help here, please? |
Collaborator
Author
|
Some commentary on the implementation:
|
Collaborator
Author
|
I have now fixed the pkgdown issue. |
Collaborator
Author
|
@dincerti, I have now added some tests for this. This is now ready for review -- although admittedly this is a larger pull request than initially anticipated. |
Collaborator
Author
|
Devin:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Devin,
I have been working on a few changes to the hesim package.
For this pull request, I have implemented transition-specific costs, which currently only has an application for iCTSTMs.
Note that this folds in the unresolved inline extension from pull request #122.
As a signpost: I am preparing a presentation for the International Society of Clinical Biostatistics for later this month that implements cCTSTMs using ordinary differential equations. I have a gist and will prepare a pull request. I have a number of questions to ask you about that pull request:).
Sincerely, Mark.