Skip to content

Initial sync-up: v1.2.3-enhance #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AaronForce1 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Initial sync-up: v1.2.3-enhance #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b7030d
fix: during build, do not add repo url to repositories.yaml if it is …
hextrust-marcuscheng Jun 26, 2023
ff881e7
Merge branch 'support-oci' into 'master'
hextrust-marcuscheng Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions internal/build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,14 @@ func (builder *Builder) generateRepositoryConfig(repositoryConfigName string, ch
for _, dep := range chartYaml["dependencies"].([]interface{}) {
d := dep.(map[interface{}]interface{})
repositoryUrl := d["repository"].(string)

// Do not include repository url in the repositories.yaml if it is not https
// Helm does not create an [app]-index.yaml that contains all the version of the chart for non-https repo
// Including the url in the repositories.yaml will cause the helm to lookup for the index file and fail
if !strings.HasPrefix(repositoryUrl, "https://") {
continue
}

name := d["name"].(string)
username := ""
password := ""
Expand Down