-
Notifications
You must be signed in to change notification settings - Fork 88
docs: add Google-style docstrings to TransactionRecord #711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add Google-style docstrings to TransactionRecord #711
Conversation
|
Hi @DinethShakya23 approved, please rebase else let me know if I should do it for you :) |
|
Hi @exploreriii , |
|
Hi @DinethShakya23 when you merge from main you may lose the signatures if not done correctly |
|
@exploreriii Got it. I will try to rebase my branch using git rebase main -S to keep the commits verified. |
Signed-off-by: DinethShakya23 <dinethshakya19@gmail.com>
3ee18db to
7d70486
Compare
|
Hi @exploreriii , I think I have completed the rebase as requested. Rebased the branch onto the latest main using "git rebase -S" to ensure the commits remain GPG-signed & merge conflict in CHANGELOG.md was resolved manually & the commit (7d70486) now includes both the DCO sign-off and a valid GPG signature. Please let me know if everything looks good from your side. |
exploreriii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Should be good! Let's wait for the final tests |
|
@exploreriii |
|
That's right, thank you very much! |
|
@exploreriii Thank you! Appreciate your help and guidance!!! |

Description:
Add comprehensive Google-style docstrings to the
TransactionRecordclass to improve documentation quality, maintainability, and developer understanding.transaction_record.pyTransactionRecordclass, documenting all dataclass fields__repr__(),_from_proto()explaining its conversion process from protobuf to Python objects &_to_proto()detailing serialization back to protobuf format.CHANGELOG.mdRelated issue(s):
Fixes #683
Notes for reviewer:
This PR introduces documentation-only changes — no functional code or logic has been modified.
Checklist