-
-
Notifications
You must be signed in to change notification settings - Fork 59
[WIP] Investigate ticket #1886: Division with scalar value issue #579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
67bdb92
3b9a0a5
36f54bf
b34d164
b3e8e6e
6848f0e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| . |
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please revert update to exprtk submodule. The current release of exprtk does not compile with our code.
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @copilot ^^
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Reverted the exprtk submodule update to the previous commit. Commit: 6848f0e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change can't be correct. The accumulated arguments for a divide operation should be multiplication, not division. Also - the example provided in the ticket does not have multiple arguments attached to the port, so won't be affected by this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted the change. You're correct - the accumulated arguments for divide should use multiplication. The original code was correct for multi-wire accumulation.
Since the ticket example doesn't have multiple arguments on a port, the issue must be in the element-wise division logic elsewhere. Further investigation is needed to find the actual root cause.
Commit: 6848f0e