Skip to content

Add comprehensive unit tests for Minsky class methods #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Add comprehensive unit tests for Minsky class methods #583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c60155a
Initial plan
Copilot Nov 15, 2025
fd13eea
Add comprehensive tests for Minsky class methods
Copilot Nov 15, 2025
75dd60f
Add necessary includes for new tests
Copilot Nov 15, 2025
8125bec
Add additional comprehensive tests for Minsky class
Copilot Nov 15, 2025
a0f1645
Fix test issues: remove private method call, fix Dimension constructo…
Copilot Nov 18, 2025
af53538
Fix unit tests.
highperformancecoder Nov 19, 2025
a3728b0
Address review comments: use unique temp file and improve assertions
Copilot Nov 20, 2025
2b5f87f
Address comprehensive code review feedback
Copilot Nov 20, 2025
e5be990
Address additional code review feedback
Copilot Nov 20, 2025
161f9ed
Address final code review comments
Copilot Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions model/minsky.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,10 +519,6 @@ namespace minsky
void nameCurrentItem(const std::string& name) {namedItems[name]=canvas.item;}
void itemFromNamedItem(const std::string& name) {canvas.item=namedItems[name].lock();}

/// trigger checkMem callback for testing purposes
bool triggerCheckMemAllocationCallback() const
{return checkMemAllocation(std::numeric_limits<size_t>::max());}

VariablePane variablePane;

/// Used to implement a pause until return pressed for attaching debugger purposes
Expand Down
Loading
Loading