Conversation
bt-cryptomancer
left a comment
bt-cryptomancer
left a comment
There was a problem hiding this comment.
The number of my comments is getting less with each review, so that means you're making progress! This is looking a lot better, just some minor things still remaining. See comments below.
…sWitness Allow for partial proposeRound and rotate out witnesses without signature
…either near deadline or has enough signatures
…oadcast simplify custom json send to round proposition handler
…oadcast Fix witness multi broadcast in p2p plugin
…oadcast fix partial broadcast case again while not having multiple broadcasts
bt-cryptomancer
left a comment
bt-cryptomancer
left a comment
There was a problem hiding this comment.
Almost done! Just a few more very minor things to adjust. See comments below.
bt-cryptomancer
left a comment
bt-cryptomancer
left a comment
There was a problem hiding this comment.
Still some things that need fixing. Please see comments below.
bt-cryptomancer
left a comment
bt-cryptomancer
left a comment
There was a problem hiding this comment.
It looks like this PR has gotten screwed up somehow. There should not be any changes to any other smart contracts besides burndollar or any other minified files. Please find and revert whatever change caused that to happen, or else close this PR and make a new one if it's too difficult to fix.
| "start": "node --max-old-space-size=8192 app.js", | ||
| "lint": "eslint .gitignore .", | ||
| "lintfix": "eslint .gitignore . --fix", | ||
| "minify:files": "for file in contracts/*.js; do if expr \"$file\" : '.*_minify\\.js$' >/dev/null; then continue; fi; filename=$(basename \"$file\" .js); terser \"$file\" --keep-fnames -c -o \"contracts/${filename}_minify.js\"; done", |
There was a problem hiding this comment.
Why did you remove this? The only change you should need to make to this file is adding in a new line for your burndollar test cases.
|
attempting to fix my issues a final time |
3 participants
The purpose of burndollar is to allow a token issuer to create a related token XXX.D allowing users to burn some of the parent token and get a D. Token.