Validate HE Full Sync on IVM code#116
Draft
forkyishere wants to merge 5 commits intohive-engine:qafrom
Draft
Conversation
Blocks 1351741, 13552906 and 1354493 had market contract events for the orderClosed that were processing orders with txId = null, causing a divergence from what old vm2 would process. By interpreting the API calls the right way (treating undefined as undefined instead of null), this fixes the issue as those 3 (actually 4, as there is another sell one too) orders not showing the "txId" field on those 4 transactions.
Fix undefined buy book market entries as null on ivm
Contributor
Author
|
Implemented (76828f1) as per suggestion from @eonwarped (thanks for the help and dedication on this). Will continue the sync and make updates here as I go. Currently at HE block 1383444. |
… from ShmoogleOsukami Fix when mainBlock is null when not comparing with hashVerificationNode
Contributor
Author
|
The next blocks being worked out are after (including) HE block 2618450, which I need to still confirm and replay/sync until a change was made around the block 5790000 (not yet confirmed). After I reach that block, I will be able to add the commits to this MR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aiming to do a full sync of the Hive Engine chain to prove that we can replay from scratch.
Issues solved so far (this will get updated until the sync finishes):