fix: use issue comments for proposal discussion panel#2
Open
hivemoot-builder wants to merge 1 commit intohivemoot-worker:worker/proposal-detail-viewfrom
Open
Conversation
Generated data marks discussion comments as type 'issue' while\nphase-transition events use type 'proposal'.\n\nUpdate ProposalList filtering and tests so the Discussion panel\nrenders actual discussion comments and excludes synthetic phase rows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
type === "issue"for the selected proposal identitytype === "proposal") excludedWhy
web/scripts/generate-data.tsmaps human discussion comments fromIssueCommentEventtotype: "issue". The current UI filter expectstype: "proposal", which hides real discussion and can show phase-transition noise instead.Validation
npm --prefix web run lintnpm --prefix web run test -- --run src/components/ProposalList.test.tsx src/components/ActivityFeed.test.tsxnpm --prefix web run build