Verify SHA of only diffed mods#5
Merged
fifty-six merged 9 commits intohk-modding:mainfrom May 3, 2025
Merged
Conversation
SFGrenade
approved these changes
Apr 30, 2025
fifty-six
requested changes
Apr 30, 2025
Member
fifty-six
left a comment
fifty-six
left a comment
There was a problem hiding this comment.
I put in a couple things for code cleanliness and perf. If you want I can also merge it and handle it instead
- Remove additional condition
- Remove Description and Dependencies fields from manifest deserialization
Closed
fifty-six
requested changes
May 2, 2025
|
|
||
| checks.Add(CheckSingleSha(manifest)); | ||
| var incomingManifest = (Manifest?)serializer.Deserialize(incomingReader) ?? throw new InvalidDataException(); | ||
| TrimManifest(ref incomingManifest); |
Member
There was a problem hiding this comment.
Might want to use a custom deserializer for this? Just on Link itself. If you don't feel like it, I can do that part
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.