-
Notifications
You must be signed in to change notification settings - Fork 14
WaitForElementsRemovedFromDOMAsync for Page and IFrame; ClickAtRandomPointAsync for IElementHandle #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Nice to see that someone actually use this. I haven't maintained this project for a while, so I took the time to bump |
|
There are probably more extension methods that could be added to |
|
@rexTexTau Nice contributions ❤️ Could you add tests for the new methods? |
Probably. I'll check it out. Adding tests for ClickAtRandomPointAsync seems to be not a very good idea, but as for WaitForElementsRemovedFromDOMAsync - it'll be nice to cover this method by tests. |
Added test methods for WaitForElementsRemovedFromDOMAsync. See commits 65802a9 and 48df96b |
I totally agree, but have no time to do that job at the moment. |
|
I published a release out of courtesy to the users of this project; https://github.com/hlaueriksson/puppeteer-sharp-contrib/releases/tag/v7.0.0 I have not used PuppeteerSharp for years. If I need to run tests in the browser, I use; https://github.com/microsoft/playwright-dotnet The contributions in this PR should go in a
Right now I don't have the incentive to maintain this project. |
Thanks for recommendation, I'll play with it. Maybe it will even fit my needs better than Puppeteer.
A tempting offer, but quite a responsibility. Need some time to ponder |
New extension for IPage and IFrame:
◼️ WaitForElementsRemovedFromDOMAsync (handy to wait for spinner to disappear etc)
New extension for IElementHandle:
◼️ ClickAtRandomPointAsync (useful in case of need to emulate a click in detailed manner)