DTSSTCI-1330: Amend Bundle to be shown in drop down menu#2443
DTSSTCI-1330: Amend Bundle to be shown in drop down menu#2443
Conversation
CCD diff summary👉 Full report: https://github.com/hmcts/sptribs-case-api/actions/runs/22220819989?check_suite_focus=true CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/caseworker-wa-task-configuration.json
AuthorisationCaseField/caseworker-st_cic-senior-judge.json
AuthorisationCaseField/caseworker-st_cic-senior-caseworker.json
AuthorisationCaseField/caseworker-st_cic-respondent.json
AuthorisationCaseField/caseworker-st_cic-judge.json
AuthorisationCaseField/caseworker-st_cic-hearing-centre-team-leader.json
AuthorisationCaseField/caseworker-st_cic-hearing-centre-admin.json
AuthorisationCaseField/caseworker-st_cic-caseworker.json
AuthorisationCaseField/caseworker-sptribs-systemupdate.json
AuthorisationCaseField/caseworker-sptribs-superuser.json
AuthorisationCaseField/CREATOR.json
CaseEvent/editBundle.json
CaseEventToFields/editBundle.json
|
CCD diff summary👉 Full report: https://github.com/hmcts/sptribs-case-api/actions/runs/22352759334?check_suite_focus=true CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/caseworker-wa-task-configuration.json
AuthorisationCaseField/caseworker-st_cic-senior-judge.json
AuthorisationCaseField/caseworker-st_cic-senior-caseworker.json
AuthorisationCaseField/caseworker-st_cic-respondent.json
AuthorisationCaseField/caseworker-st_cic-judge.json
AuthorisationCaseField/caseworker-st_cic-hearing-centre-team-leader.json
AuthorisationCaseField/caseworker-st_cic-hearing-centre-admin.json
AuthorisationCaseField/caseworker-st_cic-caseworker.json
AuthorisationCaseField/caseworker-sptribs-systemupdate.json
AuthorisationCaseField/caseworker-sptribs-superuser.json
AuthorisationCaseField/CREATOR.json
CaseEvent/editBundle.json
CaseEventToFields/editBundle.json
|
CCD diff summary👉 Full report: https://github.com/hmcts/sptribs-case-api/actions/runs/22352867519?check_suite_focus=true CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/caseworker-wa-task-configuration.json
AuthorisationCaseField/caseworker-st_cic-senior-judge.json
AuthorisationCaseField/caseworker-st_cic-senior-caseworker.json
AuthorisationCaseField/caseworker-st_cic-respondent.json
AuthorisationCaseField/caseworker-st_cic-judge.json
AuthorisationCaseField/caseworker-st_cic-hearing-centre-team-leader.json
AuthorisationCaseField/caseworker-st_cic-hearing-centre-admin.json
AuthorisationCaseField/caseworker-st_cic-caseworker.json
AuthorisationCaseField/caseworker-sptribs-systemupdate.json
AuthorisationCaseField/caseworker-sptribs-superuser.json
AuthorisationCaseField/CREATOR.json
CaseEvent/editBundle.json
CaseEventToFields/editBundle.json
|
CCD diff summary👉 Full report: https://github.com/hmcts/sptribs-case-api/actions/runs/22353185229?check_suite_focus=true CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/caseworker-wa-task-configuration.json
AuthorisationCaseField/caseworker-st_cic-senior-judge.json
AuthorisationCaseField/caseworker-st_cic-senior-caseworker.json
AuthorisationCaseField/caseworker-st_cic-respondent.json
AuthorisationCaseField/caseworker-st_cic-judge.json
AuthorisationCaseField/caseworker-st_cic-hearing-centre-team-leader.json
AuthorisationCaseField/caseworker-st_cic-hearing-centre-admin.json
AuthorisationCaseField/caseworker-st_cic-caseworker.json
AuthorisationCaseField/caseworker-sptribs-systemupdate.json
AuthorisationCaseField/caseworker-sptribs-superuser.json
AuthorisationCaseField/CREATOR.json
CaseEvent/editBundle.json
CaseEventToFields/editBundle.json
|
CCD diff summary👉 Full report: https://github.com/hmcts/sptribs-case-api/actions/runs/22387444970?check_suite_focus=true CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/caseworker-wa-task-configuration.json
AuthorisationCaseField/caseworker-st_cic-senior-judge.json
AuthorisationCaseField/caseworker-st_cic-senior-caseworker.json
AuthorisationCaseField/caseworker-st_cic-respondent.json
AuthorisationCaseField/caseworker-st_cic-judge.json
AuthorisationCaseField/caseworker-st_cic-hearing-centre-team-leader.json
AuthorisationCaseField/caseworker-st_cic-hearing-centre-admin.json
AuthorisationCaseField/caseworker-st_cic-caseworker.json
AuthorisationCaseField/caseworker-sptribs-systemupdate.json
AuthorisationCaseField/caseworker-sptribs-superuser.json
AuthorisationCaseField/CREATOR.json
CaseEvent/editBundle.json
CaseEventToFields/editBundle.json
|
…eworkerEditBundle
CCD diff summary👉 Full report: https://github.com/hmcts/sptribs-case-api/actions/runs/22572244575?check_suite_focus=true CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/caseworker-wa-task-configuration.json
AuthorisationCaseField/caseworker-st_cic-senior-judge.json
AuthorisationCaseField/caseworker-st_cic-senior-caseworker.json
AuthorisationCaseField/caseworker-st_cic-respondent.json
AuthorisationCaseField/caseworker-st_cic-judge.json
AuthorisationCaseField/caseworker-st_cic-hearing-centre-team-leader.json
AuthorisationCaseField/caseworker-st_cic-hearing-centre-admin.json
AuthorisationCaseField/caseworker-st_cic-caseworker.json
AuthorisationCaseField/caseworker-sptribs-systemupdate.json
AuthorisationCaseField/caseworker-sptribs-superuser.json
AuthorisationCaseField/CREATOR.json
CaseEvent/editBundle.json
CaseEvent/removeBundles.json
CaseEventToFields/removeBundles.json
|
CCD diff summary👉 Full report: https://github.com/hmcts/sptribs-case-api/actions/runs/22572611844?check_suite_focus=true CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/caseworker-wa-task-configuration.json
AuthorisationCaseField/caseworker-st_cic-senior-judge.json
AuthorisationCaseField/caseworker-st_cic-senior-caseworker.json
AuthorisationCaseField/caseworker-st_cic-respondent.json
AuthorisationCaseField/caseworker-st_cic-judge.json
AuthorisationCaseField/caseworker-st_cic-hearing-centre-team-leader.json
AuthorisationCaseField/caseworker-st_cic-hearing-centre-admin.json
AuthorisationCaseField/caseworker-st_cic-caseworker.json
AuthorisationCaseField/caseworker-sptribs-systemupdate.json
AuthorisationCaseField/caseworker-sptribs-superuser.json
AuthorisationCaseField/CREATOR.json
CaseEvent/editBundle.json
CaseEvent/removeBundles.json
CaseEventToFields/removeBundles.json
|
CCD diff summary👉 Full report: https://github.com/hmcts/sptribs-case-api/actions/runs/22572997816?check_suite_focus=true CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/caseworker-wa-task-configuration.json
AuthorisationCaseField/caseworker-st_cic-senior-judge.json
AuthorisationCaseField/caseworker-st_cic-senior-caseworker.json
AuthorisationCaseField/caseworker-st_cic-respondent.json
AuthorisationCaseField/caseworker-st_cic-judge.json
AuthorisationCaseField/caseworker-st_cic-hearing-centre-team-leader.json
AuthorisationCaseField/caseworker-st_cic-hearing-centre-admin.json
AuthorisationCaseField/caseworker-st_cic-caseworker.json
AuthorisationCaseField/caseworker-sptribs-systemupdate.json
AuthorisationCaseField/caseworker-sptribs-superuser.json
AuthorisationCaseField/CREATOR.json
CaseEvent/editBundle.json
CaseEvent/removeBundles.json
CaseEventToFields/removeBundles.json
|
CCD diff summary👉 Full report: https://github.com/hmcts/sptribs-case-api/actions/runs/22580767830?check_suite_focus=true CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/caseworker-wa-task-configuration.json
AuthorisationCaseField/caseworker-st_cic-senior-judge.json
AuthorisationCaseField/caseworker-st_cic-senior-caseworker.json
AuthorisationCaseField/caseworker-st_cic-respondent.json
AuthorisationCaseField/caseworker-st_cic-judge.json
AuthorisationCaseField/caseworker-st_cic-hearing-centre-team-leader.json
AuthorisationCaseField/caseworker-st_cic-hearing-centre-admin.json
AuthorisationCaseField/caseworker-st_cic-caseworker.json
AuthorisationCaseField/caseworker-sptribs-systemupdate.json
AuthorisationCaseField/caseworker-sptribs-superuser.json
AuthorisationCaseField/CREATOR.json
CaseEvent/editBundle.json
CaseEvent/removeBundles.json
CaseEventToFields/removeBundles.json
|
CCD diff summary👉 Full report: https://github.com/hmcts/sptribs-case-api/actions/runs/22581232723?check_suite_focus=true CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/caseworker-wa-task-configuration.json
AuthorisationCaseField/caseworker-st_cic-senior-judge.json
AuthorisationCaseField/caseworker-st_cic-senior-caseworker.json
AuthorisationCaseField/caseworker-st_cic-respondent.json
AuthorisationCaseField/caseworker-st_cic-judge.json
AuthorisationCaseField/caseworker-st_cic-hearing-centre-team-leader.json
AuthorisationCaseField/caseworker-st_cic-hearing-centre-admin.json
AuthorisationCaseField/caseworker-st_cic-caseworker.json
AuthorisationCaseField/caseworker-sptribs-systemupdate.json
AuthorisationCaseField/caseworker-sptribs-superuser.json
AuthorisationCaseField/CREATOR.json
CaseEvent/editBundle.json
CaseEvent/removeBundles.json
CaseEventToFields/removeBundles.json
|
CCD diff summary👉 Full report: https://github.com/hmcts/sptribs-case-api/actions/runs/22581686796?check_suite_focus=true CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/caseworker-wa-task-configuration.json
AuthorisationCaseField/caseworker-st_cic-senior-judge.json
AuthorisationCaseField/caseworker-st_cic-senior-caseworker.json
AuthorisationCaseField/caseworker-st_cic-respondent.json
AuthorisationCaseField/caseworker-st_cic-judge.json
AuthorisationCaseField/caseworker-st_cic-hearing-centre-team-leader.json
AuthorisationCaseField/caseworker-st_cic-hearing-centre-admin.json
AuthorisationCaseField/caseworker-st_cic-caseworker.json
AuthorisationCaseField/caseworker-sptribs-systemupdate.json
AuthorisationCaseField/caseworker-sptribs-superuser.json
AuthorisationCaseField/CREATOR.json
CaseEvent/editBundle.json
CaseEvent/removeBundles.json
CaseEventToFields/removeBundles.json
|
|
|
||
| } | ||
|
|
||
| public AboutToStartOrSubmitResponse<CaseData, State> aboutToSubmit( |
There was a problem hiding this comment.
theres a lot of logic in the one method,m could you break it up into smaller parts? i.e..
buildTimestampstoDelete(..)
then
buildAndRemoveIdsToDelete(),
.....
| } | ||
| } | ||
|
|
||
| for (ListValue<BundleIdAndTimestamp> bundleIdAndTimestampToBeRemoved : idsAndTimestampsOfBundlesToBeRemoved) { |
There was a problem hiding this comment.
i think you can cut down the amount of for loops here unless im missing something? our system has lowish load but if we had a lot more requests then we would need to think more about this :)
for example, using removeifs instead of one loop to build then another to remove, does this make sense?
example of remove if:
caseData.getCaseBundleIdsAndTimestamps().removeIf(bundleIdAndTimestamp ->
idsOfBundlesToBeRemoved.contains(bundleIdAndTimestamp.getValue().getBundleId())
);
CCD diff summary👉 Full report: https://github.com/hmcts/sptribs-case-api/actions/runs/22665402903?check_suite_focus=true CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/caseworker-wa-task-configuration.json
AuthorisationCaseField/caseworker-st_cic-senior-judge.json
AuthorisationCaseField/caseworker-st_cic-senior-caseworker.json
AuthorisationCaseField/caseworker-st_cic-respondent.json
AuthorisationCaseField/caseworker-st_cic-judge.json
AuthorisationCaseField/caseworker-st_cic-hearing-centre-team-leader.json
AuthorisationCaseField/caseworker-st_cic-hearing-centre-admin.json
AuthorisationCaseField/caseworker-st_cic-caseworker.json
AuthorisationCaseField/caseworker-sptribs-systemupdate.json
AuthorisationCaseField/caseworker-sptribs-superuser.json
AuthorisationCaseField/CREATOR.json
CaseEvent/editBundle.json
CaseEvent/removeBundles.json
CaseEventToFields/removeBundles.json
|
CCD diff summary👉 Full report: https://github.com/hmcts/sptribs-case-api/actions/runs/22667383689?check_suite_focus=true CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/caseworker-wa-task-configuration.json
AuthorisationCaseField/caseworker-st_cic-senior-judge.json
AuthorisationCaseField/caseworker-st_cic-senior-caseworker.json
AuthorisationCaseField/caseworker-st_cic-respondent.json
AuthorisationCaseField/caseworker-st_cic-judge.json
AuthorisationCaseField/caseworker-st_cic-hearing-centre-team-leader.json
AuthorisationCaseField/caseworker-st_cic-hearing-centre-admin.json
AuthorisationCaseField/caseworker-st_cic-caseworker.json
AuthorisationCaseField/caseworker-sptribs-systemupdate.json
AuthorisationCaseField/caseworker-sptribs-superuser.json
AuthorisationCaseField/CREATOR.json
CaseEvent/editBundle.json
CaseEvent/removeBundles.json
CaseEventToFields/removeBundles.json
|
CCD diff summary👉 Full report: https://github.com/hmcts/sptribs-case-api/actions/runs/23188201815?check_suite_focus=true CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/caseworker-wa-task-configuration.json
AuthorisationCaseField/caseworker-st_cic-senior-judge.json
AuthorisationCaseField/caseworker-st_cic-senior-caseworker.json
AuthorisationCaseField/caseworker-st_cic-respondent.json
AuthorisationCaseField/caseworker-st_cic-judge.json
AuthorisationCaseField/caseworker-st_cic-hearing-centre-team-leader.json
AuthorisationCaseField/caseworker-st_cic-hearing-centre-admin.json
AuthorisationCaseField/caseworker-st_cic-caseworker.json
AuthorisationCaseField/caseworker-sptribs-systemupdate.json
AuthorisationCaseField/caseworker-sptribs-superuser.json
AuthorisationCaseField/CREATOR.json
CaseEvent/editBundle.json
CaseEvent/removeBundles.json
CaseEventToFields/removeBundles.json
|
CCD diff summary👉 Full report: https://github.com/hmcts/sptribs-case-api/actions/runs/23341989762?check_suite_focus=true CaseField.json
AuthorisationCaseEvent/AuthorisationCaseEvent.json
AuthorisationCaseField/caseworker-wa-task-configuration.json
AuthorisationCaseField/caseworker-st_cic-senior-judge.json
AuthorisationCaseField/caseworker-st_cic-senior-caseworker.json
AuthorisationCaseField/caseworker-st_cic-respondent.json
AuthorisationCaseField/caseworker-st_cic-judge.json
AuthorisationCaseField/caseworker-st_cic-hearing-centre-team-leader.json
AuthorisationCaseField/caseworker-st_cic-hearing-centre-admin.json
AuthorisationCaseField/caseworker-st_cic-caseworker.json
AuthorisationCaseField/caseworker-sptribs-systemupdate.json
AuthorisationCaseField/caseworker-sptribs-superuser.json
AuthorisationCaseField/CREATOR.json
CaseEvent/editBundle.json
CaseEvent/removeBundles.json
CaseEventToFields/removeBundles.json
|
Change description
Create event to delete bundles (Also fixes cicCaseFieldsUtil methods)
The event does not appear when there are no bundles (including when all bundles have been deleted):


Multiple selection of bundles to delete:

Error displayed when no bundles are selected for deletion:

CYA page (two bundles displayed have been selected for deletion):

Submitted:

JIRA link
https://tools.hmcts.net/jira/browse/DTSSTCI-1330