Migrate DMNs to API-first calls via event handlers#2467
Migrate DMNs to API-first calls via event handlers#2467
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
| } | ||
|
|
||
| private void assertNoTaskOutboxAction(long caseId, String action) { | ||
| await().atMost(Duration.ofSeconds(20)).untilAsserted(() -> { |
There was a problem hiding this comment.
Is this await() approach correct here? The task outbox would have been empty at the start of the test, so if the adding of tasks to the DB is async then the assertion might be run before any (unexpected) task is added and pass the condition immediately. I suspect that for that scenario it would be better to have a sleep for N seconds before running the assertion, without using await()
Having said that, aren't the case creation and update events synchronous calls, and the addition of tasks to the outbox also synchronous?
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
# Conflicts: # src/main/java/uk/gov/hmcts/sptribs/caseworker/event/CaseworkerCreateAndSendOrder.java # src/main/java/uk/gov/hmcts/sptribs/caseworker/event/CaseworkerSendOrder.java # src/test/java/uk/gov/hmcts/sptribs/caseworker/event/CaseWorkerManageOrderDueDatesTest.java # src/test/java/uk/gov/hmcts/sptribs/caseworker/event/CaseworkerCreateAndSendOrderTest.java # src/test/java/uk/gov/hmcts/sptribs/caseworker/event/CaseworkerSendOrderTest.java
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This reverts commit 7c56a3f.
CCD diff summary👉 Full report: https://github.com/hmcts/sptribs-case-api/actions/runs/23044740169?check_suite_focus=true CaseEvent/system-trigger-stitch-collate-hearing-bundle.json
CaseEvent/system-trigger-complete-hearing-outcome.json
CaseEvent/respondent-document-management.json
CaseEvent/refer-to-legal-officer.json
CaseEvent/refer-to-judge.json
CaseEvent/edit-case.json
CaseEvent/createBundle.json
CaseEvent/create-hearing-summary.json
CaseEvent/create-draft-order.json
CaseEvent/create-and-send-order.json
CaseEvent/contact-parties.json
CaseEvent/citizen-cic-submit-dss-application.json
CaseEvent/citizen-cic-dss-update-case.json
CaseEvent/caseworker-update-anonymity.json
CaseEvent/caseworker-send-order.json
CaseEvent/caseworker-record-listing.json
CaseEvent/caseworker-postpone-hearing.json
CaseEvent/caseworker-issue-final-decision.json
CaseEvent/caseworker-issue-decision.json
CaseEvent/caseworker-issue-case.json
CaseEvent/caseworker-edit-record-listing.json
CaseEvent/caseworker-edit-draft-order.json
CaseEvent/caseworker-document-management.json
CaseEvent/caseworker-close-the-case.json
CaseEvent/caseworker-case-built.json
CaseEvent/caseworker-cancel-hearing.json
CaseEvent/caseworker-amend-due-date.json
CaseEvent/caseworker-amend-document.json
CaseEvent/caseworker-add-note.json
CaseEventToFields/respondent-document-management.json
CaseEventToFields/refer-to-legal-officer.json
CaseEventToFields/refer-to-judge.json
CaseEventToFields/edit-case.json
CaseEventToFields/create-hearing-summary.json
CaseEventToFields/create-draft-order.json
CaseEventToFields/create-and-send-order.json
|
Change description
Enter a description.
JIRA link
https://tools.hmcts.net/jira/browse/DTSSTCI-
Before merging a pull request make sure that:
enable-e2e-testslabel can be used to run the e2e tests before QA handover and before release (required)If this ticket will have any visible impact on users and is not behind a feature toggle, make sure that:
Note that bug fixes, dependency updates and technical tasks do not directly impact the user experience and can be merged without QA and PO review.
If this user story cannot be immediately merged find a way to put it behind a feature toggle and get it merged.