Add testing support for Xcode 16.2 and below#292
Open
Mcrich23 wants to merge 4 commits intohmlongco:mainfrom
Open
Add testing support for Xcode 16.2 and below#292Mcrich23 wants to merge 4 commits intohmlongco:mainfrom
Mcrich23 wants to merge 4 commits intohmlongco:mainfrom
Conversation
Owner
|
Considering this, btw, but it has conflicts with main and develop. |
Contributor
Author
|
Interesting...I'm using it on my project without issue |
Contributor
Author
|
What version of Xcode are you using? Is it possible that the compiler flags are the problem? |
Contributor
|
@Mcrich23 Please take |
Comment on lines
+54
to
+55
| // Only clone swift-testing if required | ||
| ] + getOpenSourceSwiftTestingPackageDependency(), |
Contributor
There was a problem hiding this comment.
nit Name the func in a way that doesn't require actual comment
Suggested change
| // Only clone swift-testing if required | |
| ] + getOpenSourceSwiftTestingPackageDependency(), | |
| ] + openSourceSwiftTestingDependencyForOlderSwiftVersion(), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FactoryTesting uses a feature of SwiftTesting only available in Xcode 16.3 and newer. To enable compatibility with previous Xcode versions, I added the open source version of SwiftTesting to the package manifest. To keep sizes down, I made it only clone on versions with the compiler as 6.0 or lower.