refactor: refactored auth services to use interfaces #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NwokoyeChigozie
requested changes
Mar 2, 2025
| } | ||
|
|
||
| reqData, err := auth.ValidateCreateUserRequest(req, base.Db.Postgresql.DB()) | ||
| newAuthService := authService.NewAuthService(base.Db.Postgresql.DB()) |
Contributor
There was a problem hiding this comment.
Take this out of here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To improve code modularity, testability, and adherence to the dependency inversion principle, category services where refactored to utilize interfaces.
Related Issue (Link to Github issue)
#367
How Has This Been Tested?
I ran automated and reliable test files that have been pre-written after creating a docker container to simulate the environment. Also used postman to test the endpoints.
Screenshots:
Types of changes
Checklist: