-
Notifications
You must be signed in to change notification settings - Fork 0
Fix/external terms and privacy #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @Buch-dev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a comprehensive UI/UX overhaul for key external-facing pages, ensuring a polished and responsive design for the Privacy Policy and Terms & Conditions. It also introduces dynamic visual elements to the homepage's key metrics and enhances the user experience in the dashboard by providing clear loading indicators. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request significantly improves the user interface and experience across several pages. The privacy policy and terms pages have been completely restyled for a much cleaner and more professional look, which aligns with the 'pixel perfect' goal. Additionally, the introduction of a loading state on the category edit page and scroll-triggered animations for key metrics on the home page are excellent UX enhancements. The code for these new features is well-implemented. I have two suggestions for the terms/page.tsx file: one to fix a potential hydration error and another to improve UI consistency with the privacy policy page.
| { id: "contact-information", label: "15. Contact Information" }, | ||
| ]; | ||
|
|
||
| export default function TermsPage() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a better and more consistent user experience, consider implementing active section highlighting in the Table of Contents as the user scrolls, similar to what has been done on the Privacy Policy page. This involves using useState and useEffect with an IntersectionObserver to track the visible section and apply a different style to the active link in the sidebar.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Updated the Home, Terms and Policy Pages to be Pixel Perfect