Emit camelCase keys in as_json() to match OTBR REST API spec#239
Open
jnilo1 wants to merge 1 commit intohome-assistant-libs:mainfrom
Open
Emit camelCase keys in as_json() to match OTBR REST API spec#239jnilo1 wants to merge 1 commit intohome-assistant-libs:mainfrom
jnilo1 wants to merge 1 commit intohome-assistant-libs:mainfrom
Conversation
Commit 5e5197a added _normalize_keys() to accept camelCase in GET responses, but as_json() still emitted PascalCase in PUT requests. The upstream ot-br-posix REST API uses cJSON_GetObjectItemCaseSensitive to parse incoming payloads, so PascalCase keys are silently rejected. Add _to_camel_keys() (inverse of _normalize_keys) and apply it in as_json() for Timestamp, SecurityPolicy, ActiveDataSet and PendingDataSet. GET parsing is unchanged (both cases still accepted). Fixes home-assistant-libs#238
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_to_camel_keys()(inverse of_normalize_keys()) and apply it inas_json()forTimestamp,SecurityPolicy,ActiveDataSetandPendingDataSet_normalize_keys()Context
Commit 5e5197a (shipped in v2.9.0) fixed
from_json()to accept camelCase GET responses, butas_json()still emitted PascalCase in PUT requests. Upstreamot-br-posixusescJSON_GetObjectItemCaseSensitiveto parse incoming payloads, so PascalCase keys are silently rejected — causing "Failed to call OTBR API" errors in Home Assistant when changing Thread channel or dataset.Fixes #238
Test plan
as_json()camelCase serializationfrom_json(as_json(x)) == x