fix(ci): use pip install /build to auto-resolve Lambda Dockerfile deps #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rfile The Docker/Lambda CI tests were failing because the Dockerfile.bundle-builder was missing pydantic-settings and attrs dependencies that honeyhive requires. Also updates TODO.md to document resolved test fixes and remaining implementation issues. Co-Authored-By: skylar@honeyhive.ai <skylarmb@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
📚 Documentation Preview Built✅ Documentation preview is ready! 📦 Download PreviewDownload documentation artifact 🔍 How to Review
✅ Validation Status
Preview generated for PR #164 |
…ct.toml Instead of manually listing dependencies (which was missing rich, pydantic-settings, etc), install honeyhive from the project source which automatically picks up all dependencies from pyproject.toml. This is more maintainable and won't break when new deps are added. Tested locally: docker build succeeds and import verification passes. Co-Authored-By: skylar@honeyhive.ai <skylarmb@gmail.com>
devin-ai-integration
bot
changed the title
Contributor
📚 Documentation Preview Built✅ Documentation preview is ready! 📦 Download PreviewDownload documentation artifact 🔍 How to Review
✅ Validation Status
Preview generated for PR #164 |
Co-Authored-By: skylar@honeyhive.ai <skylarmb@gmail.com>
skylarmb
approved these changes
Dec 12, 2025
Contributor
📚 Documentation Preview Built✅ Documentation preview is ready! 📦 Download PreviewDownload documentation artifact 🔍 How to Review
✅ Validation Status
Preview generated for PR #164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Docker/Lambda CI failures by changing the dependency installation approach in
tests/lambda/Dockerfile.bundle-builder. Instead of manually listing dependencies (which was missingrich,pydantic-settings, etc.), the Dockerfile now uses:RUN pip install --target . /buildThis automatically picks up all dependencies from
pyproject.toml, making it more maintainable and preventing future breakage when new dependencies are added.Also updates
TODO.mdto document the current state of test failures after the test API fixes that were pushed directly togenerate-v1.x(commits 3a8d052, 3b99361).Updates since last revision
pip install --target . /buildimport honeyhive; from honeyhive.tracer import HoneyHiveTracer)COPY src/honeyhive ./honeyhive/since pip install handles thisevent_typevalidation issue in TODO.md (pre-existing issue:basic_tracing.pyusesevent_type="lambda"which is invalid)CI Status
event_type="lambda"is not a valid value - must be one of: session, model, tool, chain). This is documented in TODO.md.generate-v1.xbranch (unrelated to this PR)Review & Testing Checklist for Human
Recommended test plan: Merge this PR to fix the Docker dependency issue. The Lambda
event_typevalidation issue should be addressed in a separate PR by changingevent_type="lambda"toevent_type="tool"intests/lambda/lambda_functions/basic_tracing.py.Notes