Skip to content

fix inefficient member writes #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jahleeljackson wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix inefficient member writes #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/user/NewJoinTeam.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React, { useState } from "react";
import { getAuth } from "firebase/auth";
import { set, ref, get } from "firebase/database";
import { update, ref, get } from "firebase/database";
import { database } from '../firebase.js'

function NewJoinTeam() {
Expand Down Expand Up @@ -45,10 +45,12 @@ function NewJoinTeam() {
// Append current UID if not already in the array
if (!members.includes(userCredential.uid)) {
members.push(userCredential.uid);
await update(teamRef, { members });
} else {
alert("You're already a member of this team!");
return;
}

// Overwrite members attribute in Firebase
await set(ref(database, `teams/${teamId}/members`), members);


console.log(`User ${userCredential.uid} added to team ${teamId}`);
alert(`Successfully joined team ${teamId}!`);
Expand Down