Skip to content
This repository was archived by the owner on Feb 5, 2025. It is now read-only.

feat: SDK generated with 2025-01-01-next schema#24

Draft
alexluong wants to merge 2 commits intohookdeck:masterfrom
alexluong:2025-01-01-next
Draft

feat: SDK generated with 2025-01-01-next schema#24
alexluong wants to merge 2 commits intohookdeck:masterfrom
alexluong:2025-01-01-next

Conversation

@alexluong
Copy link

@alexluong alexluong commented Jan 29, 2025

@leggetter
Copy link
Contributor

@alexluong - this looks right to me.

Only thing I could see is that there's a file ignored in .fernignore that's been deleted. So we should remove the reference in .fernignore.

When we're ready to release, we do so from the schema repo and pass a version in.

What I have realized about the release process is that you can only release from the default branch. So, it doesn't currently support an automated way of doing a patch release on an older version. We could change the release process to also take an optional branch to perform the release from.

@alexluong
Copy link
Author

alexluong commented Jan 29, 2025

So I think when the new code generated from the schema repo ended up here, we can make the manual changes like this branch and do a release afterward?

With that said, it'd be great if we can sort this out so we don't have to ignore these files if possible.

@leggetter
Copy link
Contributor

So I think when the new code generated from the schema repo ended up here, we can make the manual changes like this branch and do a release afterward?

I believe that the .fernignore should stop the generator from overwriting the files that are ignored. So, you only need to put the fixes in place once. Obviously, you need to be aware of any change that should result in a new file being generated.

With that said, it'd be great if we can sort this out so we don't have to ignore these files if possible.

Agreed. Let's get some feedback from Fern.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants