Skip to content

Delay adding of runtime field groups #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Delay adding of runtime field groups #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
346ea7a
Delay adding of runtime field groups
davejtoews Mar 17, 2017
0bc58c4
Preserve field order
davejtoews Jul 5, 2017
8561b9a
Merge branch 'master' of https://github.com/hoppinger/advanced-custom…
Oct 5, 2017
9715762
Prevent duplicate field groups on import
sebastiaandegeus Nov 23, 2017
7e448b4
Merge pull request #89 from hoppinger/bugfix/prevent_duplicates_on_im…
sebastiaandegeus Nov 30, 2017
2812507
Load runtime groups on acf/init hook to allow registration of fields …
sebastiaandegeus Nov 30, 2017
538f8c8
Preserve field order
davejtoews Jul 5, 2017
76b66d2
Merge branch 'master' of https://github.com/davejtoews/advanced-custo…
Dec 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/acfwpcli.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public function __construct() {

public function actions() {
if ( ! defined( 'WP_CLI' ) ) {
add_action( 'plugins_loaded', array( $this, 'add_runtime_fieldgroups' ) );
add_action( 'acf/init', array( $this, 'add_runtime_fieldgroups' ) );
}
}

Expand Down
2 changes: 1 addition & 1 deletion lib/acfwpcli/field.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

class Field {

public static function import( $field, $field_group ) {
public static function import( $field, $field_group, &$order ) {
$order = [];

// add parent
Expand Down
24 changes: 21 additions & 3 deletions lib/acfwpcli/field_group.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,25 @@ class FieldGroup {

public static function import( $file ) {
$field_groups = self::from_json_file( $file );
$order = array();

foreach ( $field_groups as $field_group ) {
$fields = acf_extract_var( $field_group, 'fields' );
$fields = acf_prepare_fields_for_import( $fields );

$db_field_group = self::find_by_key($field_group['key']);

if ($db_field_group) {
$field_group['ID'] = $db_field_group->ID;
}

$field_group = acf_update_field_group( $field_group );

// add to order
$order[ $field_group['ID'] ] = 0;

foreach ( $fields as $field ) {
Field::import( $field, $field_group );
Field::import( $field, $field_group, $order );
}
}

Expand All @@ -44,6 +54,15 @@ public static function find_by_name( $name ) {
return $results;
}

public static function find_by_key( $key ) {
global $wpdb;
$query = "SELECT * FROM {$wpdb->posts} WHERE post_type='acf-field-group' AND post_name = %s";

$results = $wpdb->get_row( $wpdb->prepare( $query, $key ) );

return $results;
}

public static function destroy( $id ) {
global $wpdb;

Expand Down Expand Up @@ -84,8 +103,7 @@ public static function to_array( $id ) {
// prepare fields
$fields = acf_prepare_fields_for_export( $fields );

// extract field group ID
acf_extract_var( $field_group, 'ID' );
$field_group['ID'] = false;

// add to field group
$field_group['fields'] = $fields;
Expand Down