Fix: Support readonly=1 users by conditionally setting query settings#471
Open
guoyi8 wants to merge 1 commit intohousepower:masterfrom
Open
Fix: Support readonly=1 users by conditionally setting query settings#471guoyi8 wants to merge 1 commit intohousepower:masterfrom
guoyi8 wants to merge 1 commit intohousepower:masterfrom
Conversation
Problem: Users with readonly=1 cannot use clickhouse-native-jdbc because the driver unconditionally sets max_result_rows and result_overflow_mode settings, which violates the readonly=1 restriction. Solution: Only set these settings when maxRows > 0 (explicitly requested). This allows readonly=1 users to use the driver while preserving setMaxRows() functionality for other users. Benefits: - ✅ Supports readonly=1 users (recommended production config) - ✅ Maintains backward compatibility - ✅ Minimal code change (5 lines) - ✅ Follows principle: "don't set what you don't need" Tested: - ✅ Works with readonly=1 users (without setMaxRows) - ✅ Works with SQL LIMIT (recommended approach) - ✅ setMaxRows() still works for readonly=0 and readonly=2 Related issues: - ClickHouse/clickhouse-java#324 - ClickHouse/clickhouse-java#2441 - grafana/clickhouse-datasource#325 - dbeaver#38280
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Users with readonly=1 cannot use clickhouse-native-jdbc because the driver unconditionally sets max_result_rows and result_overflow_mode settings, which violates the readonly=1 restriction.
Solution:
Only set these settings when maxRows > 0 (explicitly requested). This allows readonly=1 users to use the driver while preserving setMaxRows() functionality for other users.
Benefits:
Tested:
Related issues:
readonlyClickHouse/clickhouse-java#2441